Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TransactionInput.index and Coin type #187

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Conversation

rhyslbw
Copy link
Contributor

@rhyslbw rhyslbw commented Jun 5, 2020

Closes #182 by removing the index field as per discussion in IntersectMBO/cardano-db-sync#106

Also removes the additional Coin model, as the added abstraction here is unnecessary, and imposes a variation with the Hasura model.

@rhyslbw rhyslbw self-assigned this Jun 5, 2020
@rhyslbw rhyslbw changed the title Remove TransactionInput.index and Coin type Remove TransactionInput.index Jun 5, 2020
@rhyslbw rhyslbw marked this pull request as draft June 5, 2020 07:12
@rhyslbw rhyslbw marked this pull request as ready for review June 8, 2020 08:57
@rhyslbw rhyslbw changed the title Remove TransactionInput.index Remove TransactionInput.index and Coin type Jun 8, 2020
@rhyslbw rhyslbw merged commit 60ebe21 into master Jun 8, 2020
@rhyslbw rhyslbw deleted the fix/remove-inputs-index branch June 8, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatched TransactionInput.index
1 participant