Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate PBFT VrF checks #1590

Merged
merged 3 commits into from
Jun 30, 2020
Merged

Reinstate PBFT VrF checks #1590

merged 3 commits into from
Jun 30, 2020

Conversation

nc6
Copy link
Contributor

@nc6 nc6 commented Jun 25, 2020

No description provided.

@nc6 nc6 requested a review from mrBliss June 25, 2020 14:02
@uroboros
Copy link
Contributor

@nc6 I see the Examples unit tests are failing with [PrtclFailure (OverlayFailure (VRFKeyBadNonce ...))]

@nc6
Copy link
Contributor Author

nc6 commented Jun 26, 2020

Interesting! Good that this is being caught in local testing, not just the consensus testing.

@mrBliss mrBliss mentioned this pull request Jun 26, 2020
Merged
JaredCorduan
JaredCorduan approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nc6 nc6 merged commit 04e9719 into master Jun 30, 2020
@iohk-bors iohk-bors bot deleted the nc/reinstate-pbft-vrf branch June 30, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@uroboros uroboros uroboros approved these changes

@mrBliss mrBliss Awaiting requested review from mrBliss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nc6 @uroboros @JaredCorduan