Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix POOLREAP in the case of multiple pools sharing a reward account #1605

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Fix POOLREAP in the case of multiple pools sharing a reward account #1605

merged 1 commit into from
Jul 1, 2020

Conversation

uroboros
Copy link
Contributor

@uroboros uroboros commented Jul 1, 2020

This fixes another cause of UnexpectedDepositPot failures...

In the POOLREAP rule we were doing a Map.fromList on a list of tuples like so:

[(rewardAccount1, rewardAmt), (rewardAccount2, rewardAmt), ...]

but in the case of multiple pools sharing a reward account, this would lose ADA!
We need a Map.fromListWith (+) instead.

@uroboros uroboros requested review from JaredCorduan and nc6 July 1, 2020 16:23
JaredCorduan
JaredCorduan approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@uroboros uroboros merged commit cc1ce6b into master Jul 1, 2020
@uroboros uroboros deleted the uroboros/fix_pools_sharing_rwd_acnt branch July 1, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@nc6 nc6 Awaiting requested review from nc6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uroboros @JaredCorduan