Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delegation update should be union override RIGHT #1701

Merged
merged 2 commits into from
Jul 22, 2020
Merged

delegation update should be union override RIGHT #1701

merged 2 commits into from
Jul 22, 2020

Conversation

JaredCorduan
Copy link
Contributor

The nightly tests caught this bug. In the DELEG rule, the delegation certificate should perform a union override right (not left).

The test that caught it was credentialMappingAfterDelegation.

dcoutts
dcoutts approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaredCorduan JaredCorduan merged commit a5b92b6 into master Jul 22, 2020
@iohk-bors iohk-bors bot deleted the jc/delegation-update-union-override-right branch July 22, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoutts dcoutts dcoutts approved these changes

@uroboros uroboros Awaiting requested review from uroboros

@redxaxder redxaxder Awaiting requested review from redxaxder

@TimSheard TimSheard Awaiting requested review from TimSheard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaredCorduan @dcoutts