Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace dependency on lens with microlens #1705

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Replace dependency on lens with microlens #1705

merged 1 commit into from
Jul 24, 2020

Conversation

mrBliss
Copy link
Contributor

@mrBliss mrBliss commented Jul 23, 2020

No description provided.

@mrBliss mrBliss requested a review from nc6 as a code owner July 23, 2020 16:13
@mrBliss
Copy link
Contributor Author

mrBliss commented Jul 23, 2020

Not a priority now, of course. But I'd like to get rid of the dependency on the whole Kmettoverse to bring down the time spent on compiling dependencies.

Since goblins still depends on lens, this PR alone is not enough. I don't have commit access to goblins, but I have a PR open in a fork.

JaredCorduan
JaredCorduan approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful, thank you! 🔬

@mrBliss mrBliss mentioned this pull request Jul 24, 2020
Merged
iohk-bors bot added a commit to IntersectMBO/cardano-node that referenced this pull request Jul 24, 2020
@iohk-bors @mrBliss
Merge #1542
83154fc 
1542: Minor dependency trimming r=mrBliss a=mrBliss

I was actually hoping to remove all dependencies on the ledger testsuites, which bring in `lens`, `goblins`, the byron spec ledger (totally unused by `cardano-node`), but the ledger testsuites are used by the tests of the node.

I'm getting rid of `lens` in another way here: IntersectMBO/cardano-ledger#1705

So this PR barely does any dependency trimming, but it would have been a shame to throw away this minor cleanup.

Co-authored-by: Thomas Winant <thomas@well-typed.com>
@JaredCorduan JaredCorduan merged commit be1e61a into master Jul 24, 2020
@iohk-bors iohk-bors bot deleted the mrBliss/microlens branch July 24, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@nc6 nc6 Awaiting requested review from nc6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrBliss @JaredCorduan