-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert back to the group serialization for ProtVer for PParams #3440
Revert back to the group serialization for ProtVer for PParams #3440
Conversation
ddb917e
to
402a98e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hmm, a golden test is failing in CI. There are no protocol parameters in the script context, so I'm confused. Edit: maybe I get it, the golden test needs to deserialize the entire transaction so it can create the script context. and a transaction can have a ppup. |
Nah, its not that. PParams are generated because they are needed for TxInfo translation. But they also need to be stored somewhere. This one is easy, all I need is rerun the generator for txInfo translation golden tests. FYI, this problem does not apply to #3441 |
oh, you mean to get a major protocol version? |
|
Description
Revert back to the group serialization for ProtVer for PParams. This PR fixes the same problem with PParams serialization that was fixed in #3297, but it fixes in a slightly more backwards compatible manner. Namely it, as before #3297, unrolls ProtocolVersion into a list, except it properly adjusts the number of elements in the list.
Both Alonzo and Babbage PParams were affected and fixed in this PR.
Implementation in this PR was discussed here CardanoSolutions/ogmios#314 (comment)
Note the new version in the CHANGELOG, this is because this fix is getting backported to 1.2.1 versions in #3441
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)