Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate intermediate tx body cli format #4277

Closed
9 of 13 tasks
Tracked by #4144
, #4301
...
Jimbo4350 opened this issue Aug 5, 2022 · 2 comments · Fixed by #4303
Closed
9 of 13 tasks
Tracked by #4144
, #4301
...

Deprecate intermediate tx body cli format #4277

Jimbo4350 opened this issue Aug 5, 2022 · 2 comments · Fixed by #4303
Assignees
@Jimbo4350
Labels
enhancement New feature or request type: internal feature Non user-facing functionality user type: internal Created by an IOG employee

Comments

@Jimbo4350
Copy link
Contributor

Jimbo4350 commented Aug 5, 2022 •
edited
Loading

What

Remove the ability to create tx bodies with the intermediate cli format. We want all transaction bodies to be serialized in the CDDL format. Note we maintain backwards compatibility for now, i.e we can still read tx bodies with the intermediate cli format.

Why

Having two serialization formats for the transaction body will create compatibility issues in the ecosystem. We don't have a good justification for this, therefore we want to only use the CDDL format.

Personas - Who will this affect?

  • SPO
  • Dapp Devs
  • Exchanges

Acceptance Criteria

  • When building a transaction the user no longer has the options --cddl-format and --cli-format for the output transaction body.

  • The resulting transaction body from building transactions is always cddl formatted.

  • A transaction body created using --cli-format (i.e. created with a previous version) can still be signed and submitted to the chain successfully.

  • A transaction body created with --cddl-format (i.e with a previous version) can be signed and submitted successfully

Definition of done

  • Code review
  • Builds successfully on CI
  • Includes documentation and/or examples for the functionality - N/A
  • Log/record changes on Vnext (or similar depending on what we adopt)
  • Ticket number included in PR description
  • The new functionality is covered by dev/unit/property tests
  • Acceptance Criteria met
  • Test Engineering Sign-off + E2E automated tests

Sign-off

  • Dev
  • Test Engineering

Related
@Jimbo4350 Jimbo4350 added the enhancement New feature or request label Aug 5, 2022
@CarlosLopezDeLara CarlosLopezDeLara mentioned this issue Aug 11, 2022
Open
8 tasks
@CarlosLopezDeLara
Copy link
Contributor

PR --> #4303

@dorin100
Copy link

@CarlosLopezDeLara does this ticket have any impact on any user functionalities? if yes, we would need Acceptance Criteria for it. If not, the acceptance criteria could state that this change will be transparent for the end users.

@CarlosLopezDeLara CarlosLopezDeLara mentioned this issue Aug 31, 2022
Merged
@dorin100 dorin100 mentioned this issue Sep 21, 2022
Closed
@CarlosLopezDeLara CarlosLopezDeLara mentioned this issue Sep 21, 2022
Open
40 tasks
iohk-bors bot added a commit that referenced this issue Sep 22, 2022
@iohk-bors @Jimbo4350
Merge #4303
351f3f3 
4303: Deprecate intermediate txbody format r=Jimbo4350 a=Jimbo4350

- You can no longer create tx bodies with the cli's intermediate format. 
- The flags `--cddl-format` and `--cli-format` are no longer available, we default to the CDDL format 

closes [#4277](#4277)

Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
iohk-bors bot added a commit that referenced this issue Sep 22, 2022
@iohk-bors @Jimbo4350
Merge #4303
15f2160 
4303: Deprecate intermediate txbody format r=Jimbo4350 a=Jimbo4350

- You can no longer create tx bodies with the cli's intermediate format. 
- The flags `--cddl-format` and `--cli-format` are no longer available, we default to the CDDL format 

closes [#4277](#4277)

Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
iohk-bors bot added a commit that referenced this issue Sep 27, 2022
@iohk-bors @Jimbo4350
Merge #4303
99d2eaf 
4303: Deprecate intermediate txbody format r=Jimbo4350 a=Jimbo4350

- You can no longer create tx bodies with the cli's intermediate format. 
- The flags `--cddl-format` and `--cli-format` are no longer available, we default to the CDDL format 

closes [#4277](#4277)

Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@iohk-bors iohk-bors bot closed this as completed in #4303 Sep 27, 2022
@dorin100 dorin100 added type: internal feature Non user-facing functionality user type: internal Created by an IOG employee labels Oct 21, 2022
@CarlosLopezDeLara CarlosLopezDeLara mentioned this issue Nov 3, 2022
Open
19 tasks
newhoggy pushed a commit to IntersectMBO/cardano-cli that referenced this issue May 24, 2023
@iohk-bors @Jimbo4350
Merge #4303
686db17 
4303: Deprecate intermediate txbody format r=Jimbo4350 a=Jimbo4350

- You can no longer create tx bodies with the cli's intermediate format. 
- The flags `--cddl-format` and `--cli-format` are no longer available, we default to the CDDL format 

closes [#4277](IntersectMBO/cardano-node#4277)

Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jimbo4350 Jimbo4350

Labels
enhancement New feature or request type: internal feature Non user-facing functionality user type: internal Created by an IOG employee
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate intermediate txbody format IntersectMBO/cardano-node
3 participants
@Jimbo4350 @dorin100 @CarlosLopezDeLara