Implement a simple stateless observation executable #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This asserts the initialization of a Hydra head is also seen by the (not yet existing) hydra-chain-observer executable
We might want to implement that strategy as an observeRawCollectTx first and see whether that aligns with the "full" observation.
ch1bo
force-pushed
the
ensemble/stateless-observation-tool
branch
from
272f149
to
4dbfa12
Compare
3 tasks
ch1bo
force-pushed
the
ensemble/stateless-observation-tool
branch
from
1eba0a4
to
c8c9a7c
Compare
This avoids passing the "too big" type into the HydraClient
This package is released with all other hydra-* packages and shares a changelog
ch1bo
force-pushed
the
ensemble/stateless-observation-tool
branch
from
90f3532
to
22a9456
Compare
This makes it clear that the hydra-node still only "cares" about commit transactions about the head it knows in the chain layer.
ch1bo
approved these changes
Nov 13, 2023
|
|
||
| prop "Does not updates UTxO state given transactions outside of Head lifecycle" $ | ||
| forAll genSequenceOfSimplePaymentTransactions $ \(utxo, txs) -> | ||
| fst (observeAll testNetworkId utxo txs) === utxo |
There was a problem hiding this comment.
@abailly-iohk Do we need this? It's no harm if the UTxO is always updated, even when nothing is observed. I think it would simplify the implementation a bit if we remove this constraint.
There was a problem hiding this comment.
It's an optimization. That is, we do not accumulate memory on unrelated transactions.
| let initials = fst3 <$> initialInitials | ||
| observation <- observeCommitTx networkId initials tx | ||
| let utxo = getKnownUTxO st | ||
| observation <- observeCommitTx networkId utxo tx |
There was a problem hiding this comment.
SB: Shouldn't we make sure we only process commits of "our head" now?
Yes. This is implicit here (as only UTxO of our head are resolvable), but could be improved by an explicit guard $ headId == commitHeadId or so.
|
Tested this manually against cabal run hydra-chain-observer -- --node-socket testnets/preprod/node.socket --testnet-magic 1 --start-chain-from "43251332.9ea784cd95687e3c90a17b6f3633b5554f25a3ceba82f860c2e4d3cb57a0b236" | jq 'select(.message.tag == "HeadInitTx")'Will output: {
"timestamp": "2023-11-13T14:17:57.570680734Z",
"threadId": 6,
"namespace": "hydra-chain-observer",
"message": {
"headId": "1185347034540e3a9c60c69a73185ebdcd3b06cd243047aea289e6b6",
"tag": "HeadInitTx"
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Created a
hydra-chain-observerexecutable, which prints a few basic observations of the head life-cycle.📋 The chain observer does connect directly to a
cardano-nodejust the same as a ydra-node` would.📋 Refactored low-level observation functions to only take
UTxOandTx(especially theobserveCommitTx).CHANGELOG updated or not needed
Documentation updated or not needed
Haddocks updated or not needed
No new TODOs introduced or explained herafter
State.hsabout a stateful generator - this will be removed once we get rid of stateful observation anyways