Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mempool: inject transactions from older eras #2371

Closed
edsko opened this issue Jul 8, 2020 · 1 comment · Fixed by #2431
Closed

Mempool: inject transactions from older eras #2371

edsko opened this issue Jul 8, 2020 · 1 comment · Fixed by #2431
Assignees
Labels
consensus issues related to ouroboros-consensus transition

Comments

@edsko
Copy link
Contributor

edsko commented Jul 8, 2020

The HFC should automatically inject transactions from one era into the next in the mempool (parameterized by a function to do so, obviously, between every consecutive pair of eras). The point of doing this is that there is client code out there that submits transactions but does not follow the chain (at least, not directly), but instead uses services such as the REST API to see if their transaction made it -- so those would continue to work even if we move to Goguen, and they haven't upgraded.

@edsko edsko added consensus issues related to ouroboros-consensus transition priority high labels Jul 8, 2020
@edsko edsko self-assigned this Jul 8, 2020
@edsko
Copy link
Contributor Author

edsko commented Jul 8, 2020

Note that it is up to every ledger then to decide whether they want to have an explicit constructor for "transaction from previous era" (with corresponding tag in the binary format) or simply design the ledgers so that transactions from previous eras can be deserialised as-is as transactions from the new era; the consensus/HFC side perspective would be unaffected by this choice.

@mrBliss mrBliss added this to the S18 2020-07-30 milestone Jul 16, 2020
edsko added a commit that referenced this issue Jul 17, 2020
iohk-bors bot added a commit that referenced this issue Jul 17, 2020
2431: Inject transactions from older eras r=edsko a=edsko

Closes #2371.

Co-authored-by: Edsko de Vries <edsko@well-typed.com>
@iohk-bors iohk-bors bot closed this as completed in 46419c4 Jul 17, 2020
@iohk-bors iohk-bors bot closed this as completed in #2431 Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus issues related to ouroboros-consensus transition
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants