Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Sharing - node handling of shared information #3959

Closed
njd42 opened this issue Aug 17, 2022 · 3 comments
Closed

Peer Sharing - node handling of shared information #3959

njd42 opened this issue Aug 17, 2022 · 3 comments
Assignees
Labels
peer-sharing Issues / PRs related to peer sharing

Comments

@njd42
Copy link
Contributor

njd42 commented Aug 17, 2022

  • what the lifecycle
    • what validation should be performed on received information
  • how does it influence current data structures
  • how does it influence governor targets
@coot
Copy link
Contributor

coot commented Aug 18, 2022

What information to pass about peers?
I think we are in agreement here. I just want to make this explicit, that we'll exchange RelayAccessPoints.

Should peers that we gossip about come with a TTL?
This would allow us to tidy up very old entries in the known peers. If TTL expires we would forget about that peer, and request new set of peers; Alternative we could re-check if the peer is still accessible and renew its TTL.

@bolt12
Copy link
Contributor

bolt12 commented Aug 18, 2022

On the receiving end of the protocol, ultimately we will receive the peers to add to our Known Set (or perhaps our Shared set). Some validation should be performed, i.e. we should only accept those peers whose validation is successful. Validation process should check:

  • If a peer is connectable (it might not be for a variety of reasons, but we should only keep peers that have higher connection potential)
  • If a peer wants to be asked (this situation is weird, we might want to accept it still, because at the time that was the way it was configured)
  • if number of peers is within the upper-limit we asked about (this should only apply if decided the requesting end sends an upper limit amount of peers to get)
  • we should also probably check if any of the peers are already known so we can discard those

Should shared peers come with a TTL?

Interesting, this can be a good idea!

@bolt12
Copy link
Contributor

bolt12 commented Aug 18, 2022

Should peers that we gossip about come with a TTL?
This would allow us to tidy up very old entries in the known peers. If TTL expires we would forget about that peer, and request new set of peers; Alternative we could re-check if the peer is still accessible and renew its TTL.

Good idea! This could be our churn mechanism.

@bolt12 bolt12 changed the title Gossip - node handling of gossiped information Gossip - node handling of shared information Aug 26, 2022
@bolt12 bolt12 changed the title Gossip - node handling of shared information Peer Sharing - node handling of shared information Aug 26, 2022
@bolt12 bolt12 closed this as completed Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peer-sharing Issues / PRs related to peer sharing
Projects
None yet
Development

No branches or pull requests

4 participants