Decoder failure's context #2360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
added
block-fetch
coot
force-pushed
the
coot/deserialise-failure
branch
2 times, most recently
from
5c2a343
to
6382597
Compare
karknu
approved these changes
Jul 6, 2020
ouroboros-network-framework/src/Ouroboros/Network/Protocol/Handshake/Codec.hs
Outdated
Show resolved
Hide resolved
This allows us to use a bearer with 10s timeout on receiving or sending a single SDU for handshake protocol, and 30s timeout for all other mini-protocols.
ShowProxy class exposes a single method of type `Proxy p -> String`.
The Decoderfailure is raised by `runPeerWithDriver`; this patch extends its context to contain protocol name as well as protocol state.
Including ouroboros-network-framework and ourobors-network components.
The ProtocolLimitFailure is raised by the `runDecoderWithLimit`; This patch extends its context to contain protocol name as well as protocol state.
Including ouroboros-network-framework and ouroboros-network components.
coot
force-pushed
the
coot/deserialise-failure
branch
from
6382597
to
e6c4e54
Compare
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of patches fixes issue #1964; For
DeserialiseFailureProtocolLimitFailurewe include additional context: the error constructors contain singleton for
the corresponding protocol state. Together with the
ShowProxyclass& instances for all mini-protocols, this allows to log protocol name & the
state.