Configurable BlockFetch parameters #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrBliss
suggested changes
Jul 7, 2020
mrBliss
changed the title
mrBliss
reviewed
Jul 7, 2020
| @@ -145,6 +146,12 @@ data RunNodeArgs blk = RunNodeArgs { | |||
| -- | |||
| -- Use 'defaultClockSkew' when unsure. | |||
| , rnMaxClockSkew :: ClockSkew | |||
|
|
|||
There was a problem hiding this comment.
The principle I originally had in mind when we introduced RunNodeArgs is to use these fields for parameters for which we can't pick default values, e.g., NetworkMagic, ProtocolInfo, etc. For NodeArgs and ChainDbArgs, we can, so we provide functions to customise them without having to force the user (i.e., cardano-node) to pick the defaults (we know better which defaults to pick).
Over the time RunNodeArgs has been changed by multiple people and the principle no longer holds. (I want to refactor/clean up this mess at some point).
That's the reason why I prefer a "customise" function instead of requiring concrete values.
Enforce some invariants with `nodeArgsEnforceInvariants`.
mrBliss
approved these changes
Jul 9, 2020
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.