Introduce QueryHardFork #2370
Merged
Introduce QueryHardFork #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrBliss
force-pushed
the
mrBliss/interpreter-query
branch
from
78090dc
to
a1b03db
Compare
mrBliss
commented
Jul 8, 2020
ouroboros-consensus/src/Ouroboros/Consensus/HardFork/History/Summary.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus/src/Ouroboros/Consensus/HardFork/Combinator/Ledger/Query.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-cardano/test/Test/Consensus/Cardano/Examples.hs
Outdated
Show resolved
Hide resolved
ouroboros-consensus-cardano/test/Test/Consensus/Cardano/Generators.hs
Outdated
Show resolved
Hide resolved
This allows you to easily refer to the `xs`.
Fixes #2365. * Introduce `QueryHardFork` for queries specific to the hard fork combinator, unrelated to any specific era. Provide a query to ask for an `Interpreter`, which can convert a slot to an epoch or time, etc. * Generalise `QueryAnytime` so that the first era can also be queried. We still require there to be more than one era. Add the `QueryAnytimeByron` pattern synonym. * Rename the `EraStart` constructor of `QueryAnytime` to `GetEraStart` for consistency. * Change the encoding format of hard fork queries. Since they are not part of the final Shelley release yet (right?!), this is fine.
mrBliss
force-pushed
the
mrBliss/interpreter-query
branch
from
a1b03db
to
43a6ab9
Compare
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2365.
Introduce
QueryHardForkfor queries specific to the hard fork combinator,unrelated to any specific era. Provide a query to ask for an
Interpreter,which can convert a slot to an epoch or time, etc.
Generalise
QueryAnytimeso that the first era can also be queried. Westill require there to be more than one era. Add the
QueryAnytimeByronpattern synonym.
Rename the
EraStartconstructor ofQueryAnytimetoGetEraStartforconsistency.
Change the encoding format of hard fork queries. Since they are not part of
the final Shelley release yet (right?!), this is fine.