Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple GNSS #1169

Closed
1 of 2 tasks
rzinke opened this issue Mar 27, 2024 · 4 comments
Closed
1 of 2 tasks

Support for multiple GNSS #1169

rzinke opened this issue Mar 27, 2024 · 4 comments

Comments

@rzinke
Copy link
Contributor

rzinke commented Mar 27, 2024

Description of the desired feature

Currently, MintPy only supports UNR solutions. It would be helpful for it to support multiple (or generic) solutions.

Describe the solution you'd like
One flag to select among different supported solutions (e.g., 'UNR', 'ESESES', 'JPL'). And a generic file structure for less common velocity/displacement formats.

Additional context
Especially useful for NISAR cal/val.

Are you willing to help implement and maintain this feature?

  • Yes
  • No

I (rzinke) will provide an initial pull request within 10 days of 27 March 2024.

@yunjunz
Copy link
Member

yunjunz commented Mar 28, 2024

Hi @rzinke, I think your solution sounds good to me. Just to put more details out, so that we could be more in sync on the design, here is what I am thinking:

  • one downloader & one reader for each GNSS solution / sources. This should give us the following variables:

    • site_name: str
    • site_lat: num
    • site_lon: num
    • datetime: 1D np.ndarray
    • dis_e: 1D np.ndarray
    • dis_n: 1D np.ndarray
    • dis_u: 1D np.ndarray
    • std_e: 1D np.ndarray
    • std_n: 1D np.ndarray
    • std_u: 1D np.ndarray
  • other functions should be generic, including the search function given the SNWE and time period of interest, with an additional flag for the source/solution; and the analysis functions based on the above variables.

I would be more than happy to answer any questions if there is, please do not hesitate to let me know.

@rzinke
Copy link
Contributor Author

rzinke commented Mar 28, 2024

Hi @yunjunz, thanks for information--this is very helpful, and matches with what I deduced from the code. I'm definitely happy to hear thoughts and work with fellow developers on this.

@rzinke
Copy link
Contributor Author

rzinke commented Apr 3, 2024

Hello @yunjunz, @falkamelung, I have finalized pull request #1173 in which I have adapted mintpy/objects/gps to work with multiple GNSS data sources. I have tested the objects and functions in the gps module, as well as "downstream" routines such as view.py, tsview.py, plot.py, and insar_vs_gps.py. The pull request is waiting for at least one reviewer. What is the process for finding reviewers?

@yunjunz
Copy link
Member

yunjunz commented Apr 3, 2024

Thank you @rzinke for the PR! I will take a look at this later this week.

@yunjunz yunjunz assigned rzinke and unassigned rzinke Apr 3, 2024
@yunjunz yunjunz closed this as completed Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants