You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First thoughts:
I've tried to avoid nwb needing to have React in dependencies (which is why redbox-noreact exists)
Second thoughts:
Why?
First thoughts:
Shut up.
Enzyme has a peerDependency on React, which makes it problematic to include in a global install of nwb (and for a local install when using nwb for non-React projects, which will generate peerDependency installation or warnings depending on your version of npm).
Second thoughts:
Why is it problematic for a global install?
So what if non-React projects pull in another few React dependencies?
There are already a bunch of React-specific dependencies - shouldn't these be split out into a separate nwb-react module which gets included in React project skeletons?
First thoughts:
Having different versions of React installed locally and globally opens up the possibility of having two different versions of React in play - a global Enzyme dependency will resolve nwb's version of React first.
Third thoughts:
Is this really an effective way to find out why you've done things the way you've done them and if you've really done the work to validate your own assumptions?
Get some sleep
Related Twitter thread: https://twitter.com/jbscript/status/740949154264813569
The text was updated successfully, but these errors were encountered: