Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't handle npm link'd dependencies #2

Open
sindresorhus opened this issue May 4, 2016 · 2 comments
Open

Doesn't handle npm link'd dependencies #2

sindresorhus opened this issue May 4, 2016 · 2 comments
Labels

Comments

@sindresorhus
Copy link

If I have a dependency npm link'd into my node_modules folder, this tool throws. It should ignore those dependencies.

/usr/local/lib/node_modules/package-config-checker/bin/package-config-checker.js:10
var fileExists = require('file-exists')
      ^

TypeError: Path must be a string. Received undefined
    at assertPath (path.js:8:11)
    at Object.posix.join (path.js:479:5)
    at check (/usr/local/lib/node_modules/package-config-checker/bin/package-config-checker.js:65:28)
    at /usr/local/lib/node_modules/package-config-checker/bin/package-config-checker.js:75:5
    at Array.forEach (native)
    at check (/usr/local/lib/node_modules/package-config-checker/bin/package-config-checker.js:74:34)
    at /usr/local/lib/node_modules/package-config-checker/bin/package-config-checker.js:75:5
    at Array.forEach (native)
    at check (/usr/local/lib/node_modules/package-config-checker/bin/package-config-checker.js:74:34)
    at /usr/local/lib/node_modules/package-config-checker/bin/package-config-checker.js:75:5
@insin insin added the bug label May 4, 2016
@insin
Copy link
Owner

insin commented May 4, 2016

I think using realPath instead of path from read-installed's results should fix this.

@insin insin self-assigned this Jul 21, 2016
@insin insin closed this as completed in 1c80159 Jul 21, 2016
@insin
Copy link
Owner

insin commented Jul 21, 2016

FFS GitHub I said try to fix as I couldn't duplicate this locally with a simple link to a neighboring repo.

Does 1.0.1 fix this?

@insin insin reopened this Jul 21, 2016
@insin insin removed their assignment Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants