Skip to content
This repository has been archived by the owner on Aug 24, 2023. It is now read-only.

fix(model): adopt latest model structure #7

Merged
merged 6 commits into from
Apr 5, 2023

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Apr 5, 2023

Because

  • removal of model instance concept in VDP

This commit

  • adopt latest model structure
  • cleanup unused modules

@linear
Copy link

linear bot commented Apr 5, 2023

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 8.82% and project coverage change: +0.72 🎉

Comparison is base (dba5512) 14.92% compared to head (a990cea) 15.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   14.92%   15.64%   +0.72%     
==========================================
  Files           4        4              
  Lines         583      556      -27     
==========================================
  Hits           87       87              
+ Misses        489      462      -27     
  Partials        7        7              
Flag Coverage Δ
unittests 15.64% <8.82%> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/service/connector.go 0.00% <0.00%> (ø)
pkg/service/model.go 0.00% <0.00%> (ø)
pkg/service/pipeline.go 0.00% <0.00%> (ø)
pkg/service/service.go 32.83% <75.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@heiruwu heiruwu merged commit d5c4264 into main Apr 5, 2023
@heiruwu heiruwu deleted the heiru/ins-396-adopt-removal-of-model-instance branch April 5, 2023 15:10
heiruwu pushed a commit that referenced this pull request Apr 7, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.1.0-alpha](v0.0.0-alpha...v0.1.0-alpha)
(2023-04-07)


### Features

* control loop for model state monitoring
([#1](#1))
([a692c76](a692c76))


### Bug Fixes

* add missing integration test files
([#6](#6))
([bdb8eb7](bdb8eb7))
* hotfix dockerfile
([96555e5](96555e5))
* **model:** adopt latest model structure
([#7](#7))
([d5c4264](d5c4264))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
pinglin pushed a commit that referenced this pull request Apr 8, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.1.0-alpha](v0.0.0-alpha...v0.1.0-alpha)
(2023-04-08)


### Features

* control loop for model state monitoring
([#1](#1))
([a692c76](a692c76))


### Bug Fixes

* add missing integration test files
([#6](#6))
([bdb8eb7](bdb8eb7))
* hotfix dockerfile
([96555e5](96555e5))
* **model:** adopt latest model structure
([#7](#7))
([d5c4264](d5c4264))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant