Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default value of repository_file.branch parameter is not consistent with GitHub API #1132

Closed
galargh opened this issue Apr 28, 2022 · 3 comments · Fixed by #1128 or #1129
Closed
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented

Comments

@galargh
Copy link
Contributor

galargh commented Apr 28, 2022

Affected Resource(s)

Please list the resources as a list, for example:

  • github_repository_file
  • data.github_repository_file

Expected Behavior

The branch parameter of repository_file resource/data source is consistent with the GitHub API and defaults to the name of the default branch of the repository (see: https://docs.github.com/en/rest/repos/contents#create-or-update-file-contents--parameters).

Actual Behavior

The branch parameter of repository_file resource/data source defaults to main. (see: https://registry.terraform.io/providers/integrations/github/latest/docs/resources/repository_file#argument-reference + https://registry.terraform.io/providers/integrations/github/latest/docs/data-sources/repository_file#argument-reference)

References

@github-actions
Copy link

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Jan 24, 2023
@galargh
Copy link
Contributor Author

galargh commented Jan 24, 2023

This issue is very much still unresolved.

@github-actions github-actions bot removed the Status: Stale Used by stalebot to clean house label Jan 25, 2023
@kfcampbell kfcampbell added Type: Bug Something isn't working as documented Priority: Normal labels Feb 3, 2023
@nickfloyd nickfloyd added the Status: Up for grabs Issues that are ready to be worked on by anyone label Feb 10, 2023
@galargh
Copy link
Contributor Author

galargh commented Apr 1, 2023

@kfcampbell Would you mind reopening this? It was fixed for the data source when #1129 you merged (thank you 🙇) but it still needs to be fixed for the resource #1128.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Bug Something isn't working as documented
Projects
None yet
3 participants