Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/github_team_membership: Make role updatable #137

Merged
merged 2 commits into from
Aug 16, 2018
Merged

resource/github_team_membership: Make role updatable #137

merged 2 commits into from
Aug 16, 2018

Conversation

radeksimko
Copy link
Contributor

Fixes #85

TF_ACC=1 go test ./github -v -run=TestAccGithubTeamMembership_ -timeout 120m
=== RUN   TestAccGithubTeamMembership_basic
--- PASS: TestAccGithubTeamMembership_basic (4.67s)
=== RUN   TestAccGithubTeamMembership_importBasic
--- PASS: TestAccGithubTeamMembership_importBasic (2.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-github/github	6.838s

TF_ACC=1 go test ./github -v -run=TestAccGithubMembership -timeout 120m
=== RUN   TestAccGithubMembership_basic
--- PASS: TestAccGithubMembership_basic (2.58s)
=== RUN   TestAccGithubMembership_importBasic
--- PASS: TestAccGithubMembership_importBasic (1.38s)
PASS
ok  	github.com/terraform-providers/terraform-provider-github/github	3.984s

@radeksimko radeksimko added the Type: Feature New feature or request label Aug 16, 2018
@radeksimko radeksimko mentioned this pull request Aug 16, 2018
Closed
appilon
appilon approved these changes Aug 16, 2018
View reviewed changes
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the update function was copypasta of the create function? I like PRs with more deletions than additions :)

@radeksimko
Copy link
Contributor Author

I guess the update function was copypasta of the create function?

Yep

I like PRs with more deletions than additions :)

So do I :)

@radeksimko radeksimko merged commit 26f20e7 into master Aug 16, 2018
@radeksimko radeksimko deleted the b-team-membership branch August 16, 2018 21:27
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
@radeksimko
Merge pull request integrations#137 from terraform-providers/b-team-m…
611c1cd 
…embership

resource/github_team_membership: Make role updatable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appilon appilon appilon approved these changes

Assignees
No one assigned
Labels
Type: Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @appilon