r/github_repository_webhook: Add import #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds import functionality to the `github_repository_webhook` resource. ``` $ make testacc TEST=./github TESTARGS="-run=TestAccGithubRepositoryWebhook_importBasic" ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./github -v -run=TestAccGithubRepositoryWebhook_importBasic -timeout 120m === RUN TestAccGithubRepositoryWebhook_importBasic --- PASS: TestAccGithubRepositoryWebhook_importBasic (3.75s) PASS ok github.com/terraform-providers/terraform-provider-github/github 3.753s ```
radeksimko
approved these changes
Jul 5, 2017
|
|
||
| ## Import | ||
|
|
||
| Repository Webhooks can be imported using the `name` of the repository, combined with the `id` of the webhook`, separated by a `/` character. |
There was a problem hiding this comment.
I think there's one extra backtick here. 👀
| @@ -14,6 +16,17 @@ func resourceGithubRepositoryWebhook() *schema.Resource { | |||
| Read: resourceGithubRepositoryWebhookRead, | |||
| Update: resourceGithubRepositoryWebhookUpdate, | |||
| Delete: resourceGithubRepositoryWebhookDelete, | |||
| Importer: &schema.ResourceImporter{ | |||
| State: func(d *schema.ResourceData, meta interface{}) ([]*schema.ResourceData, error) { | |||
| combined := strings.Split(d.Id(), "/") | |||
There was a problem hiding this comment.
Probably a nitpick, but I this variable deserves a better name, e.g. parts or something similar that's plural.
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
…webhook r/github_repository_webhook: Add import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds import functionality to the
github_repository_webhookresource.Fixes: #12