request: support null for required_approving_review_count

[skeggse]

Terraform Version

Terraform v0.12.13
+ provider.github v2.2.1

Affected Resource(s)

github_branch_protection.required_pull_request_reviews.required_approving_review_count

Terraform Configuration Files

resource "github_branch_protection" "default" {
  repository = github_repository.repo.name
  branch     = "master"

  enforce_admins = true

  required_status_checks {
    strict = true
  }

  required_pull_request_reviews {
    required_approving_review_count = null
  }
}

Debug Output

N/a

Panic Output

N/a

Expected Behavior

What should have happened?

The provider should have configured the branch protection without any required reviewers. The upstream service supports null for the required_approving_review_count field, and assigns it accordingly if the containing required_pull_request_reviews block is omitted.

Actual Behavior

What actually happened?

The provider configured branch protection with one reviewer, per the provider-configured default.

Steps to Reproduce

Please list the steps required to reproduce the issue, for example:

1. terraform apply

Important Factoids

Are there anything atypical about your accounts that we should know? For example: Running in EC2 Classic? Custom version of OpenStack? Tight ACLs?

Nope.

References

https://github.com/terraform-providers/terraform-provider-github/pull/181

[iniinikoski]

Also bumped into this... :|

[rradillen]

3 years later I am still running into this issue: PR 971 could also provide an acceptable fix for this bug

[github-actions]

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

[kfcampbell]

Closing as #971 has been merged and released.

[skeggse]

thank you!