Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add Github actions and dependabot in Github IP Ranges DS #784

Merged
merged 1 commit into from
May 22, 2021

Conversation

Erouan50
Copy link
Contributor

It's useful to have the IP range of Github actions to restrict traffics
of exposed resources. For example, testing the connectivity of a test
database from a Github action without opening the instance to 0.0.0.0/0.

It's useful to have the IP range of Github actions to restrict traffics
of exposed resources. For example, testing the connectivity of a test
database from a Github action without opening the instance to 0.0.0.0/0.
@Erouan50
Copy link
Contributor Author

Erouan50 commented May 13, 2021

ACC Test ok:

terraform-provider-github % TF_ACC=1 go test -v ./... -run ^TestAccGithubIpRangesDataSource
?       github.com/terraform-providers/terraform-provider-github        [no test files]
=== RUN   TestAccGithubIpRangesDataSource
=== RUN   TestAccGithubIpRangesDataSource/reads_IP_ranges_without_error
=== RUN   TestAccGithubIpRangesDataSource/reads_IP_ranges_without_error/with_an_anonymous_account
    data_source_github_ip_ranges_test.go:38: anonymous account not supported for this operation
=== RUN   TestAccGithubIpRangesDataSource/reads_IP_ranges_without_error/with_an_individual_account
=== RUN   TestAccGithubIpRangesDataSource/reads_IP_ranges_without_error/with_an_organization_account
--- PASS: TestAccGithubIpRangesDataSource (3.70s)
    --- PASS: TestAccGithubIpRangesDataSource/reads_IP_ranges_without_error (3.70s)
        --- SKIP: TestAccGithubIpRangesDataSource/reads_IP_ranges_without_error/with_an_anonymous_account (0.00s)
        --- PASS: TestAccGithubIpRangesDataSource/reads_IP_ranges_without_error/with_an_individual_account (1.96s)
        --- PASS: TestAccGithubIpRangesDataSource/reads_IP_ranges_without_error/with_an_organization_account (1.74s)
PASS
ok      github.com/terraform-providers/terraform-provider-github/github 3.729s

@jcudit jcudit added this to the v4.10.0 milestone May 21, 2021
Copy link
Contributor

@jcudit jcudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@jcudit jcudit merged commit 3e539be into integrations:master May 22, 2021
jcudit pushed a commit that referenced this pull request Jun 16, 2021
It's useful to have the IP range of Github actions to restrict traffics
of exposed resources. For example, testing the connectivity of a test
database from a Github action without opening the instance to 0.0.0.0/0.
@Erouan50 Erouan50 deleted the github-ip-ranges branch May 6, 2022 21:18
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
…rations#784)

It's useful to have the IP range of Github actions to restrict traffics
of exposed resources. For example, testing the connectivity of a test
database from a Github action without opening the instance to 0.0.0.0/0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants