Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-github version to v36.0.0 #841

Merged
merged 2 commits into from
Jul 12, 2021

Conversation

xun-guo-anzx
Copy link
Contributor

Update go-github to 36.0.0

go-github released the Go client library to 36.0.0 3 days ago.

API changes includes:

  • Add ListOptions required by ListSelectedReposForOrgSecret method. As described in change
  • As result of above change, fetch full list of selected repos in github_actions_organization_secret. Fixes issue github_actions_organization_secret problem to manage more than 30 selected_repository_ids #793
  • Convert repoID used in CreateOrUpdateEnvSecret, GetEnvSecret and DeleteEnvSecret to int from int64. Not sure why it doesn't pop up an error before but seems like this is not a recent change in the new version

* Update go-github to 36.0.0

go-github released the Go client library to [36.0.0][1] 3 days ago.

API changes includes:
* Add ListOptions required by ListSelectedReposForOrgSecret method. As described in change[2]
* Convert repoID used in CreateOrUpdateEnvSecret, GetEnvSecret and DeleteEnvSecret to int from int64. Not sure why it doesn't pop up an error before but seems like this is not a recent change in the new version

[1]: https://github.com/google/go-github/releases/tag/v36.0.0
[2]: google/go-github#1883
@jcudit jcudit modified the milestones: v4.13.0, v4.14.0 Jun 30, 2021
@patrickmarabeas
Copy link
Contributor

Hey @jcudit what's the timeframe for a v4.13.0 release?

@jcudit jcudit modified the milestones: v4.13.0, v4.12.2 Jul 12, 2021
@jcudit jcudit merged commit f85e6c8 into integrations:main Jul 12, 2021
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
* Update go-github version to 36.0.0

* Update go-github to 36.0.0

go-github released the Go client library to [36.0.0][1] 3 days ago.

API changes includes:
* Add ListOptions required by ListSelectedReposForOrgSecret method. As described in change[2]
* Convert repoID used in CreateOrUpdateEnvSecret, GetEnvSecret and DeleteEnvSecret to int from int64. Not sure why it doesn't pop up an error before but seems like this is not a recent change in the new version

[1]: https://github.com/google/go-github/releases/tag/v36.0.0
[2]: google/go-github#1883

* Fetch full list of selected repos in github_actions_organization_secret

Fix integrations#793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants