From 8275c08480dc0de4ddf0a2cf25a297799fcba0fc Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Mon, 24 Jul 2023 10:59:52 -0700 Subject: [PATCH] acpi-hmat-calculate-abstract-distance-with-hmat-checkpatch-fixes WARNING: Avoid logging continuation uses where feasible #54: FILE: drivers/acpi/numa/hmat.c:768: + pr_cont("read_latency: %u, write_latency: %u, read_bandwidth: %u, write_bandwidth: %u\n", WARNING: __meminitdata should be placed after hmat_adist_nb #174: FILE: drivers/acpi/numa/hmat.c:888: +static __meminitdata struct notifier_block hmat_adist_nb = ERROR: that open brace { should be on the previous line #175: FILE: drivers/acpi/numa/hmat.c:889: +static __meminitdata struct notifier_block hmat_adist_nb = +{ WARNING: From:/Signed-off-by: email name mismatch: 'From: Huang Ying ' != 'Signed-off-by: "Huang, Ying" ' total: 1 errors, 3 warnings, 185 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./patches/acpi-hmat-calculate-abstract-distance-with-hmat.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: "Huang, Ying" Signed-off-by: Andrew Morton --- drivers/acpi/numa/hmat.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c index 306a912090f035..cc98960378766e 100644 --- a/drivers/acpi/numa/hmat.c +++ b/drivers/acpi/numa/hmat.c @@ -885,8 +885,7 @@ static int hmat_calculate_adistance(struct notifier_block *self, return NOTIFY_STOP; } -static __meminitdata struct notifier_block hmat_adist_nb = -{ +static __meminitdata struct notifier_block hmat_adist_nb = { .notifier_call = hmat_calculate_adistance, .priority = 100, };