From 365d41923176f79b3c0b32df77f92521f9fa8d85 Mon Sep 17 00:00:00 2001 From: chykon <82272369+chykon@users.noreply.github.com> Date: Wed, 15 Mar 2023 18:15:37 +0300 Subject: [PATCH 1/5] Rename `BENCHMARKING.md` --- benchmark/{BENCHMARKING.md => README.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename benchmark/{BENCHMARKING.md => README.md} (100%) diff --git a/benchmark/BENCHMARKING.md b/benchmark/README.md similarity index 100% rename from benchmark/BENCHMARKING.md rename to benchmark/README.md From bc5024e87830a69ffe8a60f0a90cb6cc988a36ec Mon Sep 17 00:00:00 2001 From: chykon <82272369+chykon@users.noreply.github.com> Date: Wed, 15 Mar 2023 22:51:47 +0300 Subject: [PATCH 2/5] Edit `README.md` --- benchmark/README.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/benchmark/README.md b/benchmark/README.md index 52fe5fa12..28507734f 100644 --- a/benchmark/README.md +++ b/benchmark/README.md @@ -1,7 +1,7 @@ Benchmarking in ROHD ==================== -This folder contains some benchmarking related code for estimating relative performance of certain ROHD features. It can be used to help judge the relative performance impact with and without a change in ROHD. Benchmarks can be microbenchmarks for a specific feature, larger benchmarks for estimating performance on more realistic designs, or comparison benchmarks for similar applications relative to other frameworks and simulators. +This folder contains some benchmarking related code for estimating relative performance of certain ROHD features. It can be used to help judge the relative performance impact with and without a change in ROHD. Benchmarks can be microbenchmarks for a specific feature, larger benchmarks for estimating performance on more realistic designs, or comparison benchmarks for similar applications relative to other frameworks and simulators. To run all benchmarks, execute the below command: @@ -11,9 +11,9 @@ dart run benchmark/benchmark.dart You can run this command (or specific benchmarks) before and after a change to get a feel if any performance covered by these benchmarks has been impacted. ----------------- -2022 September 28 -Author: Max Korbel <> - -Copyright (C) 2022 Intel Corporation +----------------------------------------- +Copyright (C) 2022-2023 Intel Corporation \ SPDX-License-Identifier: BSD-3-Clause + +2022 September 28 \ +Author: Max Korbel <> From 55192f9b7d10a89f44662350a4137afa689f7eea Mon Sep 17 00:00:00 2001 From: chykon <82272369+chykon@users.noreply.github.com> Date: Wed, 15 Mar 2023 22:53:30 +0300 Subject: [PATCH 3/5] Edit `benchmark.dart` --- benchmark/benchmark.dart | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/benchmark/benchmark.dart b/benchmark/benchmark.dart index d1877d11e..c451d236f 100644 --- a/benchmark/benchmark.dart +++ b/benchmark/benchmark.dart @@ -1,12 +1,11 @@ -/// Copyright (C) 2022 Intel Corporation -/// SPDX-License-Identifier: BSD-3-Clause -/// -/// benchmark.dart -/// Runs benchmarks and prints values. -/// -/// 2022 September 28 -/// Author: Max Korbel -/// +// Copyright (C) 2022-2023 Intel Corporation +// SPDX-License-Identifier: BSD-3-Clause +// +// benchmark.dart +// Runs benchmarks and prints values. +// +// 2022 September 28 +// Author: Max Korbel import 'byte_enable_benchmark.dart'; import 'logic_value_of_benchmark.dart'; From ac30363c688c7c4420d0b8b91d877c48f502b593 Mon Sep 17 00:00:00 2001 From: chykon <82272369+chykon@users.noreply.github.com> Date: Mon, 20 Mar 2023 13:18:57 +0300 Subject: [PATCH 4/5] Edit `byte_enable_benchmark.dart` --- benchmark/byte_enable_benchmark.dart | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/benchmark/byte_enable_benchmark.dart b/benchmark/byte_enable_benchmark.dart index 10a2c85bf..6869730d0 100644 --- a/benchmark/byte_enable_benchmark.dart +++ b/benchmark/byte_enable_benchmark.dart @@ -1,20 +1,19 @@ -/// Copyright (C) 2022 Intel Corporation -/// SPDX-License-Identifier: BSD-3-Clause -/// -/// byte_enable_benchmark.dart -/// Benchmarking for simple byte enable hardware -/// -/// 2022 December 2 -/// Author: Max Korbel -/// +// Copyright (C) 2022-2023 Intel Corporation +// SPDX-License-Identifier: BSD-3-Clause +// +// byte_enable_benchmark.dart +// Benchmarking for simple byte enable hardware +// +// 2022 December 2 +// Author: Max Korbel import 'package:benchmark_harness/benchmark_harness.dart'; import 'package:rohd/rohd.dart'; class ByteEnableBenchmark extends BenchmarkBase { - late Logic result; - late Logic select; - late Logic original; + late final Logic result; + late final Logic select; + late final Logic original; static const int numBytes = 128; @@ -40,9 +39,6 @@ class ByteEnableBenchmark extends BenchmarkBase { )).swizzle(); } - @override - void teardown() {} - @override void run() { vectors.forEach(select.put); From d73c70d26dd5221c106264c4857d39426bb7a209 Mon Sep 17 00:00:00 2001 From: chykon <82272369+chykon@users.noreply.github.com> Date: Mon, 20 Mar 2023 14:42:54 +0300 Subject: [PATCH 5/5] Edit remaining benchmark files --- benchmark/logic_value_of_benchmark.dart | 24 ++++++++++-------------- benchmark/pipeline_benchmark.dart | 19 +++++++++---------- benchmark/wave_dump_benchmark.dart | 17 ++++++++--------- 3 files changed, 27 insertions(+), 33 deletions(-) diff --git a/benchmark/logic_value_of_benchmark.dart b/benchmark/logic_value_of_benchmark.dart index 9d7e57e14..8041ce075 100644 --- a/benchmark/logic_value_of_benchmark.dart +++ b/benchmark/logic_value_of_benchmark.dart @@ -1,12 +1,11 @@ -/// Copyright (C) 2022 Intel Corporation -/// SPDX-License-Identifier: BSD-3-Clause -/// -/// logic_value_of_benchmark.dart -/// Benchmarking for concatenation of values together into one. -/// -/// 2022 December 1 -/// Author: Max Korbel -/// +// Copyright (C) 2022-2023 Intel Corporation +// SPDX-License-Identifier: BSD-3-Clause +// +// logic_value_of_benchmark.dart +// Benchmarking for concatenation of values together into one. +// +// 2022 December 1 +// Author: Max Korbel import 'dart:math'; @@ -14,7 +13,7 @@ import 'package:benchmark_harness/benchmark_harness.dart'; import 'package:rohd/rohd.dart'; class LogicValueOfBenchmark extends BenchmarkBase { - late List toOf; + late final List toOf; LogicValueOfBenchmark() : super('LogicValueOf'); @@ -32,15 +31,12 @@ class LogicValueOfBenchmark extends BenchmarkBase { .join())); } - @override - void teardown() {} - @override void run() { LogicValue.of(toOf); } } -void main() async { +void main() { LogicValueOfBenchmark().report(); } diff --git a/benchmark/pipeline_benchmark.dart b/benchmark/pipeline_benchmark.dart index 457e9a29b..fc7fe9f8d 100644 --- a/benchmark/pipeline_benchmark.dart +++ b/benchmark/pipeline_benchmark.dart @@ -1,12 +1,11 @@ -/// Copyright (C) 2022 Intel Corporation -/// SPDX-License-Identifier: BSD-3-Clause -/// -/// pipeline_benchmark.dart -/// Benchmarking for pipeline simulation performance -/// -/// 2022 September 28 -/// Author: Max Korbel -/// +// Copyright (C) 2022-2023 Intel Corporation +// SPDX-License-Identifier: BSD-3-Clause +// +// pipeline_benchmark.dart +// Benchmarking for pipeline simulation performance +// +// 2022 September 28 +// Author: Max Korbel import 'package:benchmark_harness/benchmark_harness.dart'; import 'package:rohd/rohd.dart'; @@ -14,7 +13,7 @@ import 'package:rohd/src/utilities/simcompare.dart'; import '../test/pipeline_test.dart'; class PipelineBenchmark extends AsyncBenchmarkBase { - late RVPipelineModule _rvPipelineModule; + late final RVPipelineModule _rvPipelineModule; PipelineBenchmark() : super('Pipeline'); diff --git a/benchmark/wave_dump_benchmark.dart b/benchmark/wave_dump_benchmark.dart index 2d646f283..777b42eb0 100644 --- a/benchmark/wave_dump_benchmark.dart +++ b/benchmark/wave_dump_benchmark.dart @@ -1,12 +1,11 @@ -/// Copyright (C) 2023 Intel Corporation -/// SPDX-License-Identifier: BSD-3-Clause -/// -/// wave_dump_benchmark.dart -/// Benchmarking for wave dumping -/// -/// 2023 January 5 -/// Author: Max Korbel -/// +// Copyright (C) 2023 Intel Corporation +// SPDX-License-Identifier: BSD-3-Clause +// +// wave_dump_benchmark.dart +// Benchmarking for wave dumping +// +// 2023 January 5 +// Author: Max Korbel import 'dart:io';