Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate description and externalRef in favor of metadata #221

Closed
sabineschaller opened this issue Nov 17, 2022 · 2 comments · Fixed by #270
Closed

Deprecate description and externalRef in favor of metadata #221

sabineschaller opened this issue Nov 17, 2022 · 2 comments · Fixed by #270
Assignees

Comments

@sabineschaller
Copy link
Member

In some use cases, description and externalRef are overkill, where in others, it may not be enough. I vote for using metadata instead. Making it type string and stringify everything would probably be easiest.

@sabineschaller sabineschaller changed the title Deprecate description and externalRef in favor for metadata Deprecate description and externalRef in favor of metadata Nov 17, 2022
@wilsonianb
Copy link
Contributor

@adrianhopebailie
Copy link
Collaborator

Memos seems like a nice way to have SOME structure.
Basically an array of objects with a rel, type, and value.
(Odd that memos in XRPL use format for the mime-type)

Format can default to text/plain

{
  "memos": [
    {
      "rel": "invoiceNumber",
      "value": "INV542654"
    },
    {
      "rel": "description",
      "value": "Payment for the widgets"
    },
    {
      "rel": "invoice",
      "type": "application/pdf"
      "value": "<base64encoded PDF>"
    } 
  ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants