Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure API calls are held to same restrictions in real API #39

Open
idjaw opened this issue Mar 23, 2017 · 0 comments
Open

Ensure API calls are held to same restrictions in real API #39

idjaw opened this issue Mar 23, 2017 · 0 comments

Comments

@idjaw
Copy link
Contributor

idjaw commented Mar 23, 2017

Currently, the Fake-UB API is very lenient and the data that is returned is very minimal. Furthermore, it will return any extra parameters we send as data, which works contrary to how Ubersmith works.

While Ubersmith will accept any extra parameters sent to it when retrieving this data, only the data supported by the API will be returned.

Example problem:

Calling a client.add with unsupported arguments like: x='foo', y='bar' will result in those parameters being returned in a subsequent client.get.

This should not happen. We should be lenient in accepting, but only show the supported parameters.

This should be done for all implemented calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant