Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge queue not clearing completed author merges #10131

Open
mheiman opened this issue Dec 8, 2024 · 0 comments
Open

Merge queue not clearing completed author merges #10131

mheiman opened this issue Dec 8, 2024 · 0 comments
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Module: Merge Queue Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 2 Important, as time permits. [managed] Type: Bug Something isn't working. [managed]

Comments

@mheiman
Copy link
Collaborator

mheiman commented Dec 8, 2024

Problem

At some point (looks like maybe November — I never ran into before then) successful author merges are not always being automatically removed from the merge queue when they are completed. It seems to affect mainly complicated merges, where the merger may have to complete the merge in stages to clear up errors along the way.

What one is left with is a merge request that points to a single author, and therefore can no longer be closed by merging.

The merge queue currently has about 20 of these, which I've marked "Merged, but won't delete."

Reproducing the bug

I can't find any consistent set of steps that causes or prevents this behavior.

Context

  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Breakdown

I haven't done any work on the merge queue, so I'm not going to speculate about what's going wrong.

If we can't track down the problem, having an interface to manually close items would be a reasonable fix.

Stakeholders

@jimchamp @seabelis


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@mheiman mheiman added Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels Dec 8, 2024
@mekarpeles mekarpeles added Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Module: Merge Queue and removed Needs: Lead labels Dec 11, 2024
@jimchamp jimchamp added Priority: 2 Important, as time permits. [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @jimchamp Issues overseen by Jim (Front-end Lead, BookNotes) [managed] Module: Merge Queue Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Priority: 2 Important, as time permits. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

No branches or pull requests

3 participants