Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameter change enacted with only 1 DREP abstain vote #3835

Closed
CarlosLopezDeLara opened this issue Oct 31, 2023 · 0 comments · Fixed by #3836
Closed

parameter change enacted with only 1 DREP abstain vote #3835

CarlosLopezDeLara opened this issue Oct 31, 2023 · 0 comments · Fixed by #3836
Labels
bug Something isn't working conway

Comments

@CarlosLopezDeLara
Copy link

CarlosLopezDeLara commented Oct 31, 2023

A governance action that attempts to change keyDeposit gets enacted with only one DREP abstain vote. Aparently the pre-condition is that this is the first governance action of this type and there are NO cc member yet on the system

cardano-cli conway governance vote create --abstain --governance-action-tx-id 9b86469bf8f7cd78a1bf74ffa768e494e768f7ef8d466211a86c8612f699c5c6 --governance-action-index 0 --drep-verification-key-file example/dreps/drep1.vkey --out-file example/transactions/pparams-drep1.vote`
+ cardano-cli conway transaction build --testnet-magic 42 --tx-in 9b86469bf8f7cd78a1bf74ffa768e494e768f7ef8d466211a86c8612f699c5c6#0 --change-address addr_test1qzdzkxlp8pa44w9lc7ehqe4xtq3zghz7evllm2z38pw2axs0yw2mdz2ka5h0luedjtj8nc22aymdguhk4cgx5puqqscsgx4dry --vote-file example/transactions/pparams-drep1.vote --witness-override 2 --out-file example/transactions/pparams-dreps-vote-tx.raw
Estimated transaction fee: Lovelace 172849
+ cardano-cli conway transaction sign --testnet-magic 42 --tx-body-file example/transactions/pparams-dreps-vote-tx.raw --signing-key-file example/utxo-keys/payment1.skey --signing-key-file example/dreps/drep1.skey --out-file example/transactions/pparams-dreps-vote-tx.signed
+ cardano-cli conway transaction submit --testnet-magic 42 --tx-file example/transactions/pparams-dreps-vote-tx.signed
Transaction successfully submitted.
+ cardano-cli conway query gov-state --testnet-magic 42
+ jq -r .proposals.psGovActionStates
{
  "9b86469bf8f7cd78a1bf74ffa768e494e768f7ef8d466211a86c8612f699c5c6#0": {
    "action": {
      "contents": [
        null,
        {
          "keyDeposit": 5000000
        }
      ],
      "tag": "ParameterChange"
    },
    "actionId": {
      "govActionIx": 0,
      "txId": "9b86469bf8f7cd78a1bf74ffa768e494e768f7ef8d466211a86c8612f699c5c6"
    },
    "committeeVotes": {},
    "dRepVotes": {
      "keyHash-9b3f30d0b9714f58c1904050c96f16dcb9b56a9d6f9ddc9b044f2616": "Abstain"
    },
    "deposit": 1000000000,
    "expiresAfter": 3,
    "proposedIn": 2,
    "returnAddr": {
      "credential": {
        "keyHash": "0f2395b68956ed2efff32d92e479e14ae936d472f6ae106a07800431"
      },
      "network": "Testnet"
    },
    "stakePoolVotes": {}
  }
}
+ cardano-cli conway query gov-state --testnet-magic 42
+ jq -r .enactState.curPParams.keyDeposit
5000000
cardano-cli query protocol-parameters --testnet-magic 42 | jq .stakeAddressDeposit
5000000

The same issue occurs with other pparams:

cardano-cli conway query gov-state --testnet-magic 42 | jq -r .proposals
{
  "psGovActionStates": {
    "9c4fb59734cac7559cf1b0a7aa96cd0025db3e6e5e43e4db98a5f60e97ef968c#0": {
      "action": {
        "contents": [
          null,
          {
            "nOpt": 50
          }
        ],
        "tag": "ParameterChange"
      },
      "actionId": {
        "govActionIx": 0,
        "txId": "9c4fb59734cac7559cf1b0a7aa96cd0025db3e6e5e43e4db98a5f60e97ef968c"
      },
      "committeeVotes": {},
      "dRepVotes": {
        "keyHash-e519f14318eaa2607c5a4dbd65e4dda63a1b5f52430aeed0234d5987": "Abstain"
      },
      "deposit": 1000000000,
      "expiresAfter": 5,
      "proposedIn": 4,
      "returnAddr": {
        "credential": {
          "keyHash": "d241ef58562fbf1a4ae9412cc4012b88705b4aa9b0dbcf61f696ead8"
        },
        "network": "Testnet"
      },
      "stakePoolVotes": {}
    }
  },
  "psProposalOrder": [
    {
      "govActionIx": 0,
      "txId": "9c4fb59734cac7559cf1b0a7aa96cd0025db3e6e5e43e4db98a5f60e97ef968c"
    }
  ]
}
cardano-cli conway query gov-state --testnet-magic 42 | jq -r .proposals
{
  "psGovActionStates": {},
  "psProposalOrder": []
}
cardano-cli conway query gov-state --testnet-magic 42 | jq -r .enactState.curPParams.nOpt
50

cardano-node --version
cardano-node 8.6.0 - linux-x86_64 - ghc-9.2
git rev 379e4d7c95e7f9b01166922232fb39e0d10f0811

@lehins lehins added the conway label Oct 31, 2023
@lehins lehins added the bug Something isn't working label Oct 31, 2023
@lehins lehins mentioned this issue Nov 1, 2023
9 tasks
lehins added a commit that referenced this issue Nov 1, 2023
This is an alternative approach to figuring out thresholds. Original
approach was buggy and did not work correctly, which resulted in #3835
lehins added a commit that referenced this issue Nov 1, 2023
This is an alternative approach to figuring out thresholds. Original
approach was buggy and did not work correctly, which resulted in #3835
lehins added a commit that referenced this issue Nov 2, 2023
This is an alternative approach to figuring out thresholds. Original
approach was buggy and did not work correctly, which resulted in #3835
lehins added a commit that referenced this issue Nov 2, 2023
This is an alternative approach to figuring out thresholds. Original
approach was buggy and did not work correctly, which resulted in #3835
lehins added a commit that referenced this issue Nov 2, 2023
This is an alternative approach to figuring out thresholds. Original
approach was buggy and did not work correctly, which resulted in #3835

Bring back the module

Bring back the module
lehins added a commit that referenced this issue Nov 2, 2023
This is an alternative approach to figuring out thresholds. Original
approach was buggy and did not work correctly, which resulted in #3835

Bring back the module

Bring back the module
@lehins lehins added this to Conway May 20, 2024
@lehins lehins moved this to Done in Conway May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working conway
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants