Fixing the Mint field translation. #3398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disassembler
approved these changes
Apr 29, 2023
8 tasks
It was incorrectly fixed in 21825f1 This is due to the fact that the Map in Plutus is not like a Map in Haskell's containers library. Plutus Map is an assoc Map that is based on lists and the order of elements actually matters. So, the original fix placed the ADA value at the end, while the original and correct implementation, as in this commit, places it at the beginning.
lehins
force-pushed
the
lehins/fix-mint-field-translation-to-plutus
branch
from
2f3a747 to
dc446d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was incorrectly fixed in 21825f1
This is due to the fact that the Map in Plutus is not like a Map in Haskell's containers library. Plutus Map is an assoc Map that is based on lists and the order of elements actually matters. So, the original fix placed the ADA value at the end, while the original and correct implementation, as in this PR, places it at the beginning.
Description
Add your description here, if it fixes a particular issue please provide a
link
to the issue.
Checklist
CHANGELOG.mdfor affected package.cabalfiles are updatedfourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)