submit-api: add tx_submit_fail_count metric #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to `tx_submit_count` for failed submissions. Closes IntersectMBO#3233.
sorki
requested review from
DavidEichmann,
dcoutts,
erikd,
JaredCorduan,
Jimbo4350,
nc6 and
newhoggy
as code owners
|
Tested, works as expected! |
|
I guess I was not the only crazy person who thinks this metric is mandatory. |
|
I've asked @newhoggy to review this PR |
newhoggy
approved these changes
Oct 27, 2022
|
bors r+ |
|
Thanks for the PR! |
|
Build succeeded: |
wolf31o2
added a commit
to blinklabs-io/tx-submit-api
that referenced
this pull request
Oct 27, 2022
see: IntersectMBO/cardano-node#3235 Signed-off-by: Chris Gianelloni <cgianelloni@cloudstruct.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
tx_submit_countfor failed submissions.Closes #3233.