Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index state to 2022-07-01T00:00:00Z #3862

Merged
merged 7 commits into from
Jul 5, 2022
Merged

Update index state to 2022-07-01T00:00:00Z #3862

merged 7 commits into from
Jul 5, 2022

Conversation

newhoggy
Copy link
Contributor

No description provided.

@newhoggy newhoggy force-pushed the newhoggy/update-index-state branch 2 times, most recently from f7c8fe2 to c99e216 Compare May 15, 2022 23:22
@newhoggy newhoggy force-pushed the newhoggy/update-index-state branch 3 times, most recently from 7409544 to 8bab5f3 Compare May 25, 2022 12:35
@newhoggy newhoggy changed the title Update index state to 2022-05-09T00:00:00Z Update index state to 2022-05-24T00:00:00Z May 25, 2022
@newhoggy newhoggy force-pushed the newhoggy/update-index-state branch from 8bab5f3 to de715b9 Compare May 25, 2022 12:36
@newhoggy newhoggy force-pushed the newhoggy/update-index-state branch 2 times, most recently from 1e10926 to 8bfcb43 Compare June 4, 2022 13:21
@newhoggy newhoggy force-pushed the newhoggy/update-index-state branch from 201dfb7 to 2c5c11e Compare June 6, 2022 05:12
@newhoggy
Copy link
Contributor Author

newhoggy commented Jun 8, 2022

Thanks @hamishmack for the fixes!

@newhoggy newhoggy requested a review from Jimbo4350 June 10, 2022 02:11
@newhoggy newhoggy force-pushed the newhoggy/update-index-state branch 2 times, most recently from ce8f7b2 to 71f2fa0 Compare June 10, 2022 02:26
@newhoggy newhoggy dismissed Jimbo4350’s stale review June 10, 2022 02:26

Comments addressed

@newhoggy newhoggy force-pushed the newhoggy/update-index-state branch from 71f2fa0 to 170b3cb Compare June 26, 2022 13:06
@newhoggy newhoggy force-pushed the newhoggy/update-index-state branch from 446f514 to 706fc5d Compare July 4, 2022 04:36
@newhoggy newhoggy changed the title Update index state to 2022-05-24T00:00:00Z Update index state to 2022-07-01T00:00:00Z Jul 4, 2022
Jimbo4350
Jimbo4350 reviewed Jul 4, 2022
View reviewed changes
bench/locli/src/Cardano/Analysis/Chain.hs
@@ -1,6 +1,9 @@
{-# LANGUAGE GeneralizedNewtypeDeriving#-}
{-# OPTIONS_GHC -Wno-deprecations -Wno-orphans #-}

{-# OPTIONS_GHC -Wno-orphans #-}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Jimbo4350
Jimbo4350 reviewed Jul 4, 2022
View reviewed changes
cardano-api/cardano-api.cabal
@@ -217,7 +217,6 @@ test-suite cardano-api-test
, tasty
, tasty-hedgehog
, tasty-quickcheck
, tasty-th
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great. The less deps we use the better.

@Jimbo4350 Jimbo4350 self-requested a review July 4, 2022 17:19
Jimbo4350
Jimbo4350 approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for keeping an eye on this.

@newhoggy
Copy link
Contributor Author

newhoggy commented Jul 4, 2022

bors r+

iohk-bors bot added a commit that referenced this pull request Jul 4, 2022
@iohk-bors @newhoggy @hamishmack
Merge #3862
f865593 
3862: Update index state to 2022-07-01T00:00:00Z r=newhoggy a=newhoggy



Co-authored-by: John Ky <john.ky@iohk.io>
Co-authored-by: Hamish Mackenzie <Hamish.K.Mackenzie@gmail.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 4, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from MarcFontaine, cleverca22, deepfire, denisshevchenko, jutaro, and/or mgmeier.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@newhoggy
Copy link
Contributor Author

newhoggy commented Jul 5, 2022

bors r+

iohk-bors bot added a commit that referenced this pull request Jul 5, 2022
@iohk-bors @newhoggy @hamishmack
Merge #3862
ec8039f 
3862: Update index state to 2022-07-01T00:00:00Z r=newhoggy a=newhoggy



Co-authored-by: John Ky <john.ky@iohk.io>
Co-authored-by: Hamish Mackenzie <Hamish.K.Mackenzie@gmail.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 5, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from deepfire, denisshevchenko, and/or jutaro.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

MarcFontaine
MarcFontaine approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@MarcFontaine MarcFontaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@newhoggy
Copy link
Contributor Author

newhoggy commented Jul 5, 2022

bors r+

iohk-bors bot added a commit that referenced this pull request Jul 5, 2022
@iohk-bors @newhoggy @hamishmack
Merge #3862
b967f42 
3862: Update index state to 2022-07-01T00:00:00Z r=newhoggy a=newhoggy



Co-authored-by: John Ky <john.ky@iohk.io>
Co-authored-by: Hamish Mackenzie <Hamish.K.Mackenzie@gmail.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 5, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from deepfire, denisshevchenko, and/or jutaro.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@Jimbo4350
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 5, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 96a58be into master Jul 5, 2022
@iohk-bors iohk-bors bot deleted the newhoggy/update-index-state branch July 5, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleverca22 cleverca22 cleverca22 approved these changes

@MarcFontaine MarcFontaine MarcFontaine approved these changes

@denisshevchenko denisshevchenko denisshevchenko approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@DavidEichmann DavidEichmann Awaiting requested review from DavidEichmann

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@nc6 nc6 Awaiting requested review from nc6

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@deepfire deepfire Awaiting requested review from deepfire

@jutaro jutaro Awaiting requested review from jutaro

@mgmeier mgmeier Awaiting requested review from mgmeier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@newhoggy @Jimbo4350 @cleverca22 @MarcFontaine @denisshevchenko @hamishmack