Add script evaluation events to LedgerEvent #3984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliu41
requested review from
DavidEichmann,
dcoutts,
Jimbo4350,
erikd,
newhoggy,
nc6 and
JaredCorduan
as code owners
JaredCorduan
reviewed
Jun 2, 2022
There was a problem hiding this comment.
This looks good to me, but I'll leave it to @Jimbo4350 to make sure it's an approach he likes. But I'm really excited about the functionality, thanks @zliu41 !
zliu41
force-pushed
the
ledgerevent/script
branch
from
17d8f59
to
1faecc5
Compare
zliu41
force-pushed
the
ledgerevent/script
branch
from
1faecc5
to
f13a139
Compare
zliu41
force-pushed
the
ledgerevent/script
branch
from
f13a139
to
b55aec7
Compare
Jimbo4350
approved these changes
Dec 5, 2022
zliu41
force-pushed
the
ledgerevent/script
branch
3 times, most recently
from
c3b23cb
to
114cc3a
Compare
zliu41
force-pushed
the
ledgerevent/script
branch
from
114cc3a
to
0350651
Compare
zliu41
force-pushed
the
ledgerevent/script
branch
from
0350651
to
7b78455
Compare
zliu41
force-pushed
the
ledgerevent/script
branch
from
7b78455
to
67fab54
Compare
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 7, 2023
3984: Add script evaluation events to LedgerEvent r=zliu41 a=zliu41 I need to access Plutus script evalution from `LedgerEvent`: https://input-output.atlassian.net/browse/PLT-106 I'm unfamiliar with this repo so I don't know if there's a better approach, but this does seem to work. cc `@Jimbo4350` `@JaredCorduan` and thanks `@JaredCorduan` for the discussion. Co-authored-by: Ziyang Liu <unsafeFixIO@gmail.com>
|
Timed out. |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to access Plutus script evalution from
LedgerEvent: https://input-output.atlassian.net/browse/PLT-106I'm unfamiliar with this repo so I don't know if there's a better approach, but this does seem to work.
cc @Jimbo4350 @JaredCorduan and thanks @JaredCorduan for the discussion.