-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAD-4437 Include UTxO HD installation/usage instructions in READMEs #4079
Merged
jorisdral
merged 2 commits into
consensus/feature/utxo-hd
from
jdral/CAD-4437-utxo-hd-readme-instructions
Jul 6, 2022
Merged
CAD-4437 Include UTxO HD installation/usage instructions in READMEs #4079
jorisdral
merged 2 commits into
consensus/feature/utxo-hd
from
jdral/CAD-4437-utxo-hd-readme-instructions
Jul 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
force-pushed
the
jdral/CAD-4437-utxo-hd-readme-instructions
branch
from
June 24, 2022 15:04
4500e78
to
2866b36
Compare
jorisdral
requested review from
DavidEichmann,
dcoutts,
Jimbo4350,
erikd,
newhoggy,
nc6 and
JaredCorduan
as code owners
June 28, 2022 08:02
jorisdral
requested review from
dnadales and
jasagredo
and removed request for
newhoggy,
erikd,
JaredCorduan,
dcoutts,
DavidEichmann,
nc6 and
Jimbo4350
June 28, 2022 08:03
jasagredo
force-pushed
the
consensus/feature/utxo-hd
branch
from
June 28, 2022 14:38
5f33840
to
920dc37
Compare
jorisdral
requested review from
deepfire,
denisshevchenko,
jutaro,
coot,
MarcFontaine,
mgmeier and
cleverca22
as code owners
June 28, 2022 14:38
jorisdral
force-pushed
the
jdral/CAD-4437-utxo-hd-readme-instructions
branch
from
June 28, 2022 15:14
0138b1d
to
02943b6
Compare
dnadales
reviewed
Jun 28, 2022
dnadales
reviewed
Jun 28, 2022
dnadales
reviewed
Jun 28, 2022
dnadales
reviewed
Jun 28, 2022
dnadales
reviewed
Jun 28, 2022
dnadales
reviewed
Jun 28, 2022
dnadales
reviewed
Jun 28, 2022
dnadales
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Joris 🙌
Can we limit the text width to 80 characters?
jasagredo
force-pushed
the
consensus/feature/utxo-hd
branch
from
June 29, 2022 07:35
920dc37
to
b9ceb23
Compare
26 tasks
jorisdral
force-pushed
the
jdral/CAD-4437-utxo-hd-readme-instructions
branch
from
July 4, 2022 08:28
068d161
to
4649862
Compare
jasagredo
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with some comments
* Added installation/usage instructions for UTxO HD to top-level README, installation instructions, and node config file instructions. * More documentation for `defaultLMDBLimits`. * Other change: Parsing behaviour for LMDB mapsize should now allow parsing more types of units. The previous parsing behaviour would only parse 1024-based units such Mebibytes, Gibibytes, etc. Now, we can also provide 1000-based units, for example. * Fixed Redhat/Fedora/CentOS installation instructions, which was missing an instruction to install OpenSSL libraries, amongst others. * Crudely updated the Windows installation instructions; requires a Windows machine to update the instructions.
@jasagredo and @layogeshsajanikar have provided update instructions for Windows, which are based on the build steps on their Windows machines/VMs.
jorisdral
force-pushed
the
jdral/CAD-4437-utxo-hd-readme-instructions
branch
from
July 6, 2022 14:32
aa56d38
to
db9461f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to update documentation to account for the UTxO HD feature. The LMDB backend in particular requires some additional instructions to set up. The updated documentation should highlight changes in
cardano-node
usage/configuration, and changes incardano-node
installation instructions.The following documentation files have been updated:
Somewhat related is this PR in
cardano-node-tests
, which updates scripts that are used to verify that the build instructions are sufficient to build the node from scratch on Linux distributions.