Fix TraceNodeIsLeader JSON parser
#4187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy and
JaredCorduan
as code owners
|
It does, just that the test is flaky |
jasagredo
force-pushed
the
jasagredo/fix-testnet-tests-json-parsers
branch
from
b39c168
to
79de6c7
Compare
jasagredo
force-pushed
the
jasagredo/fix-testnet-tests-json-parsers
branch
from
79de6c7
to
d30cc61
Compare
newhoggy
approved these changes
Jul 19, 2022
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jul 19, 2022
4187: Fix `TraceNodeIsLeader` JSON parser r=Jasagredo a=Jasagredo
The log messages are formatted slightly different in each case. In particular:
```
{...,"data":{...,"kind":"TraceAddBlockEvent.AddedToCurrentChain","...},...}
```
versus
```
{"...,"data":{...,"val":{"kind":"TraceNodeIsLeader","slot":85}},...}
```
Also the parser was intended to only get the events with the kind `TraceNodeIsLeader`.
Co-authored-by: Javier Sagredo <jasataco@gmail.com>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Jimbo4350
reviewed
Jul 20, 2022
| k <- v .: "val" >>= (.: "kind") | ||
| if k == "TraceNodeIsLeader" | ||
| then TraceNodeIsLeader k <$> (v .: "val" >>= (.: "slot")) | ||
| else fail "Not the right kind" |
There was a problem hiding this comment.
@jasagredo @newhoggy What is the failure "Not the right kind" going to indicate to the user? What is not the right kind? The error message says pretty much nothing.
@jasagredo can you improve this message to something like "Expected kind TraceNodeIsLeader but got: " <> k
There was a problem hiding this comment.
Sure thing. This is only used in tests though, but yeah, a more informative error message would be better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log messages are formatted slightly different in each case. In particular:
versus
Also the parser was intended to only get the events with the kind
TraceNodeIsLeader.