Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use patched aeson from hackage #4200

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Use patched aeson from hackage #4200

merged 1 commit into from
Jul 22, 2022

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Jul 20, 2022 •
edited
Loading

Now that the index state has been updated, we can use the patched aeson-2.1.0.0 from hackage instead of using our fork.

This patch contains a bug fix/memory optimisation.

@newhoggy newhoggy force-pushed the newhoggy/use-patched-aeson-from-hackage branch from 6ca5373 to a5a90ba Compare July 22, 2022 01:26
@newhoggy
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 22, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit d25f48a into master Jul 22, 2022
@iohk-bors iohk-bors bot deleted the newhoggy/use-patched-aeson-from-hackage branch July 22, 2022 11:13
dermetfan added a commit to IntersectMBO/cardano-db-sync that referenced this pull request Oct 10, 2022
@dermetfan
update cardano-node to latest version that works
a6ce811 
nix eval .#tullia.x86_64-linux.task --apply __attrNames --impure

Seems that this PR broke it:
IntersectMBO/cardano-node#4200
dermetfan added a commit to IntersectMBO/cardano-db-sync that referenced this pull request Oct 10, 2022
@dermetfan
update cardano-node to get purity fix
93e519c 
I also tried to update to the latest version and apply the purity fix there.

However, it seems that this PR broke it (even in impure mode):
IntersectMBO/cardano-node#4200

Test with:
nix eval .#tullia.x86_64-linux.task --apply __attrNames --impure
dermetfan added a commit to IntersectMBO/cardano-db-sync that referenced this pull request Oct 10, 2022
@dermetfan
update cardano-node to get purity fix
2cfc58a 
Now referencing the `backport-purity-1.35.0-rc4` branch.

I also tried to update to the latest version and apply the purity fix
there (`purity` branch).

However, it seems that this PR broke it (even in impure mode):
IntersectMBO/cardano-node#4200

Test with:
nix eval .#tullia.x86_64-linux.task --apply __attrNames --impure
dermetfan added a commit to IntersectMBO/cardano-db-sync that referenced this pull request Oct 10, 2022
@dermetfan
update cardano-node to get purity fix
29de99d 
Now referencing the `backport-purity-1.35.0-rc4` branch.

I also tried to update to the latest version and apply the purity fix
there (`purity` branch).

However, it seems that this PR broke it (even in impure mode):
IntersectMBO/cardano-node#4200

Test with:
nix eval .#tullia.x86_64-linux.task --apply __attrNames --impure
dermetfan added a commit to IntersectMBO/cardano-db-sync that referenced this pull request Oct 11, 2022
@dermetfan
update cardano-node to get purity fix
976d6a5 
Now referencing the `backport-purity-1.35.0-rc4` branch.

I also tried to update to the latest version and apply the purity fix
there (`purity` branch).

However, it seems that this PR broke it (even in impure mode):
IntersectMBO/cardano-node#4200

Test with:
nix eval .#tullia.x86_64-linux.task --apply __attrNames --impure
dermetfan added a commit to IntersectMBO/cardano-db-sync that referenced this pull request Nov 10, 2022
@dermetfan
update cardano-node to get purity fix
edbc3f3 
Now referencing the `backport-purity-1.35.0-rc4` branch.

I also tried to update to the latest version and apply the purity fix
there (`purity` branch).

However, it seems that this PR broke it (even in impure mode):
IntersectMBO/cardano-node#4200

Test with:
nix eval .#tullia.x86_64-linux.task --apply __attrNames --impure
dermetfan added a commit to IntersectMBO/cardano-db-sync that referenced this pull request Nov 10, 2022
@dermetfan
update cardano-node to get purity fix
3418597 
Now referencing the `backport-purity-1.35.0-rc4` branch.

I also tried to update to the latest version and apply the purity fix
there (`purity` branch).

However, it seems that this PR broke it (even in impure mode):
IntersectMBO/cardano-node#4200

Test with:
nix eval .#tullia.x86_64-linux.task --apply __attrNames --impure
dermetfan added a commit to IntersectMBO/cardano-db-sync that referenced this pull request Nov 15, 2022
@dermetfan
update cardano-node to get purity fix
16f07de 
Now referencing the `backport-purity-1.35.0-rc4` branch.

I also tried to update to the latest version and apply the purity fix
there (`purity` branch).

However, it seems that this PR broke it (even in impure mode):
IntersectMBO/cardano-node#4200

Test with:
nix eval .#tullia.x86_64-linux.task --apply __attrNames --impure
dermetfan added a commit to IntersectMBO/cardano-db-sync that referenced this pull request Nov 17, 2022
@dermetfan
update cardano-node to get purity fix
76e328a 
Now referencing the `backport-purity-1.35.0-rc4` branch.

I also tried to update to the latest version and apply the purity fix
there (`purity` branch).

However, it seems that this PR broke it (even in impure mode):
IntersectMBO/cardano-node#4200

Test with:
nix eval .#tullia.x86_64-linux.task --apply __attrNames --impure
dermetfan added a commit to IntersectMBO/cardano-db-sync that referenced this pull request Nov 17, 2022
@dermetfan
update cardano-node to get purity fix
697a995 
Now referencing the `backport-purity-1.35.0-rc4` branch.

I also tried to update to the latest version and apply the purity fix
there (`purity` branch).

However, it seems that this PR broke it (even in impure mode):
IntersectMBO/cardano-node#4200

Test with:
nix eval .#tullia.x86_64-linux.task --apply __attrNames --impure
dermetfan added a commit to IntersectMBO/cardano-db-sync that referenced this pull request Nov 18, 2022
@dermetfan
update cardano-node to get purity fix
08a9720 
Now referencing the `backport-purity-1.35.0-rc4` branch.

I also tried to update to the latest version and apply the purity fix
there (`purity` branch).

However, it seems that this PR broke it (even in impure mode):
IntersectMBO/cardano-node#4200

Test with:
nix eval .#tullia.x86_64-linux.task --apply __attrNames --impure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@erikd erikd erikd approved these changes

@deepfire deepfire Awaiting requested review from deepfire

@denisshevchenko denisshevchenko Awaiting requested review from denisshevchenko

@jutaro jutaro Awaiting requested review from jutaro

@mgmeier mgmeier Awaiting requested review from mgmeier

@dcoutts dcoutts Awaiting requested review from dcoutts

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newhoggy @erikd @Jimbo4350