tx-generator: more declarative interface #4412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MarcFontaine
commented
Sep 2, 2022
•
MarcFontaine
commented
- Use streaming library for transaction streams.
- Include changes from tx-generator | reusable API and library #4180
use streaming library
Remove legacy 'createChange' function. Todo: fix Cardano.Benchmarking.Script.Selftest.
MarcFontaine
requested review from
deepfire,
denisshevchenko,
jutaro,
mgmeier,
fmaste and
cleverca22
as code owners
This is not a rebase but the changes where replayed/cherry-picked manually.
MarcFontaine
force-pushed
the
mafo/tx-generator-cleanup2
branch
from
85a18c3
to
000f597
Compare
mgmeier
approved these changes
Sep 12, 2022
|
bors r+ |
|
👎 Rejected by label |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.