Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate validation and creation of transaction bodies #4468

Merged
merged 4 commits into from
Sep 29, 2022
Merged

Separate validation and creation of transaction bodies #4468

merged 4 commits into from
Sep 29, 2022

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Sep 22, 2022 •
edited
Loading

Implement createTransactionBody and createAndValidateTransactionBody. We want to separate TxBody construction and validation to allow the creation of invalid transaction bodies.

Closes #3563

@Jimbo4350 Jimbo4350 force-pushed the jordan/separate-validation-in-makeTransactionBody-2 branch 6 times, most recently from 48f32d9 to f907e09 Compare September 23, 2022 09:46
@Jimbo4350 Jimbo4350 marked this pull request as ready for review September 23, 2022 10:40
@Jimbo4350 Jimbo4350 force-pushed the jordan/separate-validation-in-makeTransactionBody-2 branch 2 times, most recently from 289e2d9 to a71de15 Compare September 23, 2022 12:40
LudvikGalois
LudvikGalois approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@LudvikGalois LudvikGalois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

cardano-api/src/Cardano/Api/TxBody.hs Outdated Show resolved Hide resolved
@Jimbo4350 Jimbo4350 force-pushed the jordan/separate-validation-in-makeTransactionBody-2 branch from a71de15 to 3357439 Compare September 29, 2022 10:05
@Jimbo4350 Jimbo4350 force-pushed the jordan/separate-validation-in-makeTransactionBody-2 branch from 3357439 to c7dd93a Compare September 29, 2022 10:14
@Jimbo4350
Copy link
Contributor Author

bors r+

@Jimbo4350 Jimbo4350 mentioned this pull request Sep 29, 2022
Closed
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 29, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 59b57bd into master Sep 29, 2022
@iohk-bors iohk-bors bot deleted the jordan/separate-validation-in-makeTransactionBody-2 branch September 29, 2022 10:53
@CarlosLopezDeLara CarlosLopezDeLara mentioned this pull request Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LudvikGalois LudvikGalois LudvikGalois approved these changes

@deepfire deepfire deepfire approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy

@denisshevchenko denisshevchenko Awaiting requested review from denisshevchenko

@jutaro jutaro Awaiting requested review from jutaro

@MarcFontaine MarcFontaine Awaiting requested review from MarcFontaine

@mgmeier mgmeier Awaiting requested review from mgmeier

@fmaste fmaste Awaiting requested review from fmaste

@cleverca22 cleverca22 Awaiting requested review from cleverca22

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] - Separate tx body construction and validation
3 participants
@Jimbo4350 @deepfire @LudvikGalois