Separate IO from txBuild and txBuildRaw functions #4491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/separate-io-tx-build-2
branch
4 times, most recently
from
b77d23c
to
87cce2e
Compare
Jimbo4350
force-pushed
the
jordan/separate-io-tx-build-2
branch
4 times, most recently
from
62bb191
to
14a9d3a
Compare
Jimbo4350
requested review from
dcoutts,
erikd,
newhoggy,
JaredCorduan,
LudvikGalois and
CarlosLopezDeLara
as code owners
Jimbo4350
force-pushed
the
jordan/separate-io-tx-build-2
branch
from
14a9d3a
to
a6d7b28
Compare
newhoggy
reviewed
Oct 17, 2022
cardano-api/src/Cardano/Api/Fees.hs
Outdated
| txFee = TxFeeExplicit explicitTxFees fee, | ||
| txOuts = accountForNoChange | ||
| (TxOut changeaddr balance TxOutDatumNone ReferenceScriptNone) | ||
| (txOuts txbodycontent), | ||
| txReturnCollateral = retColl, | ||
| txTotalCollateral = reqCol | ||
| } | ||
| return (BalancedTxBody txbody3 (TxOut changeaddr balance TxOutDatumNone ReferenceScriptNone) fee) | ||
| txbody3 <- | ||
| first TxBodyError $ -- TODO: impossible to fail now |
There was a problem hiding this comment.
I think the TODO comment needs elaboration. The TODO should say what needs to be done.
There was a problem hiding this comment.
That was there previously but I'll update it
Jimbo4350
force-pushed
the
jordan/separate-io-tx-build-2
branch
from
a6d7b28
to
4e353f8
Compare
newhoggy
approved these changes
Oct 17, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step towards condensing modules responsible for reading and validating the things required for transaction construction. The end goal is to expose these modules via
cardano-apiso users can implement their own transaction construction and/or validation functions.