Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove testnet subdir #4580

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Remove testnet subdir #4580

merged 2 commits into from
Nov 2, 2022

Conversation

MarcFontaine
Copy link
Contributor

Move the modules from testnet to src.

@MarcFontaine MarcFontaine added the WIP Work In Progress (cannot be merged yet) label Oct 28, 2022
@MarcFontaine MarcFontaine self-assigned this Oct 28, 2022
@MarcFontaine
Copy link
Contributor Author

#4558

@MarcFontaine
Copy link
Contributor Author

merge after: #4544

@MarcFontaine MarcFontaine force-pushed the mafo/4558-directory-structure branch 3 times, most recently from 51f5fd5 to b08470f Compare November 1, 2022 07:59
@MarcFontaine MarcFontaine removed the WIP Work In Progress (cannot be merged yet) label Nov 1, 2022
@MarcFontaine MarcFontaine marked this pull request as ready for review November 1, 2022 09:24
@Jimbo4350
Copy link
Contributor

Jimbo4350 commented Nov 1, 2022 •
edited
Loading

So now I would do the following:

  • cardano-testnet/src/Testnet/Commands -> cardano-testnet/src/Parsers
  • cardano-testnet/src/Testnet/{Babbage,Byron,Cardano,Shelley}.hs should remain where they are and the test moved to the src dir
  • Nuke Testnet.List

Jimbo4350
Jimbo4350 approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a couple other things: #4580 (comment)

cardano-testnet/cardano-testnet.cabal

build-depends: ansi-terminal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MarcFontaine
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 2, 2022
@iohk-bors @MarcFontaine
Merge #4580
2c8e1e8 
4580: Remove testnet subdir r=MarcFontaine a=MarcFontaine

Move the modules from `testnet` to `src`.

Co-authored-by: MarcFontaine <MarcFontaine@users.noreply.github.com>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 2, 2022

Canceled.

@MarcFontaine
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 2, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 9d91363 into master Nov 2, 2022
@iohk-bors iohk-bors bot deleted the mafo/4558-directory-structure branch November 2, 2022 09:49
@Jimbo4350 Jimbo4350 mentioned this pull request Nov 3, 2022
Open
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@LudvikGalois LudvikGalois Awaiting requested review from LudvikGalois

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees

@MarcFontaine MarcFontaine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcFontaine @Jimbo4350