Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ord instance for AddressInEra #4587

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Add Ord instance for AddressInEra #4587

merged 1 commit into from
Nov 7, 2022

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Oct 31, 2022 •
edited
Loading

Co-authored-by: @UlfNorell

@Jimbo4350 Jimbo4350 mentioned this pull request Oct 31, 2022
Closed
@Jimbo4350 Jimbo4350 force-pushed the jordan/address-in-era-ord-instance branch from ac56c54 to 1e6d439 Compare October 31, 2022 18:52
@Jimbo4350 Jimbo4350 force-pushed the jordan/address-in-era-ord-instance branch from 1e6d439 to 3850685 Compare November 1, 2022 15:58
@Jimbo4350
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 1, 2022
@iohk-bors @Jimbo4350
Merge #4546 #4587
84d9a4b 
4546: Reduce exposed modules in cardano-api r=deepfire a=Jimbo4350



4587: Add Ord instance for AddressInEra r=Jimbo4350 a=Jimbo4350

Co-authored-by: `@UlfNorell`

Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 1, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"Waiting on code owner review from MarcFontaine, cleverca22, deepfire, fmaste, input-output-hk/devops, jutaro, mgmeier, and/or newhoggy.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@Jimbo4350 Jimbo4350 force-pushed the jordan/address-in-era-ord-instance branch from 3850685 to fca763a Compare November 2, 2022 15:12
@Jimbo4350
Copy link
Contributor Author

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 2, 2022
@iohk-bors @Jimbo4350
Merge #4587
5834831 
4587: Add Ord instance for AddressInEra r=Jimbo4350 a=Jimbo4350

Co-authored-by: `@UlfNorell`

Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 2, 2022

Build failed:

@Jimbo4350
Add Ord instance for AddressInEra
af5461a 
Co-authored-by: UlfNorell <ulf.norell@gmail.com>
@Jimbo4350 Jimbo4350 force-pushed the jordan/address-in-era-ord-instance branch from fca763a to af5461a Compare November 7, 2022 18:11
@Jimbo4350
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 7, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit f4dc7c4 into master Nov 7, 2022
@iohk-bors iohk-bors bot deleted the jordan/address-in-era-ord-instance branch November 7, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LudvikGalois LudvikGalois LudvikGalois approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jimbo4350 @LudvikGalois