workbench: get rid of some unnecessary complications #4694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmaste
requested review from
Jimbo4350,
newhoggy,
a team,
coot,
deepfire,
jutaro,
mgmeier,
cleverca22,
dcoutts,
erikd,
JaredCorduan,
LudvikGalois and
CarlosLopezDeLara
as code owners
|
We still need to fix the branch base & commit history. |
deepfire
force-pushed
the
bench-master
branch
from
5c4ff32
to
03be05d
Compare
|
Ok, rebase fixed -- now we need |
deepfire
force-pushed
the
bench-master
branch
from
4081698
to
5893ae2
Compare
deepfire
force-pushed
the
bench-master
branch
9 times, most recently
from
2ed43b3
to
2618910
Compare
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 7, 2022
4694: workbench: get rid of some unnecessary complications r=fmaste a=fmaste Clearer modules dependencies. The general idea is: > backendName -> useCabalRun -> backend > stateDir -> batchName -> profileName -> backend -> workbench -> runner For this: - Moved 'services-config' back to profiles and out of the backends - Moved the backend dependency out from 'all-profiles' (workbench) - Removed 'stateDir' from the backends Also: - Remove unused code and parameters (or repeated defaults) - Variable renames for clarity - Makefile fixes Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io> Co-authored-by: Federico Mastellone <federico.pascual-mastellone@iohk.io>
|
Timed out. |
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 7, 2022
4694: workbench: get rid of some unnecessary complications r=fmaste a=fmaste Clearer modules dependencies. The general idea is: > backendName -> useCabalRun -> backend > stateDir -> batchName -> profileName -> backend -> workbench -> runner For this: - Moved 'services-config' back to profiles and out of the backends - Moved the backend dependency out from 'all-profiles' (workbench) - Removed 'stateDir' from the backends Also: - Remove unused code and parameters (or repeated defaults) - Variable renames for clarity - Makefile fixes Co-authored-by: Kosyrev Serge <serge.kosyrev@iohk.io> Co-authored-by: Federico Mastellone <federico.pascual-mastellone@iohk.io>
|
Timed out. |
Co-authored-by: Federico Mastellone <federico.pascual-mastellone@iohk.io>
- Remove repeated code (services-config) from backends - Move 'services-config' to profiles and out of the backends - Move the backend dependency out from 'all-profiles' - Remove unused code and parameters or its defaults - Remove 'stateDir' from the backends - Renames for clarity
…s clutter in logs
deepfire
force-pushed
the
bench-master
branch
from
2618910
to
963afb5
Compare
|
No failures in the Loki log[1] -- merging by hand, since BORS is temporarily gone. -- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clearer modules dependencies. The general idea is:
For this:
Also: