Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append tx output in cli transaction build command #4696

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Append tx output in cli transaction build command #4696

merged 1 commit into from
Dec 7, 2022

Conversation

Jimbo4350
Copy link
Contributor

Fixes: #4658

@Jimbo4350 Jimbo4350 mentioned this pull request Dec 6, 2022
Closed
MarcFontaine
MarcFontaine approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@MarcFontaine MarcFontaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcFontaine
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 7, 2022
@iohk-bors
Merge #4696
d999e86 
4696: Append tx output in cli transaction build command r=MarcFontaine a=Jimbo4350

Fixes: #4658 

Co-authored-by: Jordan <jordan@system76-pc.localdomain>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 7, 2022

Timed out.

@Jimbo4350 Jimbo4350 merged commit 63e5a49 into master Dec 7, 2022
@iohk-bors iohk-bors bot deleted the jordan/append-change-txout-build branch December 7, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcFontaine MarcFontaine MarcFontaine approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@LudvikGalois LudvikGalois Awaiting requested review from LudvikGalois

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - Different outputs ordering before and after balancing transaction.
2 participants
@Jimbo4350 @MarcFontaine