Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ghc-9.2 and partial support for CHaP #4701

Merged
merged 19 commits into from
Feb 6, 2023
Merged

Add support for ghc-9.2 and partial support for CHaP #4701

merged 19 commits into from
Feb 6, 2023

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Dec 9, 2022

No description provided.

@erikd erikd force-pushed the erikd/ghc-9.2 branch 3 times, most recently from f8fe954 to c208ab2 Compare December 14, 2022 04:23
@erikd erikd force-pushed the erikd/ghc-9.2 branch 2 times, most recently from 7d6c325 to 7986df9 Compare December 15, 2022 06:20
@angerman
Copy link
Contributor

I think we need to

allow-newer: katip:Win32

🤦

@erikd erikd force-pushed the erikd/ghc-9.2 branch 3 times, most recently from 20d323a to bb31fbb Compare December 16, 2022 04:50
Soupstraw and others added 4 commits February 6, 2023 11:19
@Soupstraw @erikd
Added lower bounds to dependencies based on cabal.project constraints
4d132ef
@disassembler @erikd
update ouroboros-network and iohk-nix
1b8d4d5
@Soupstraw @erikd
@angerman @coot @mgmeier @Jimbo4350
Updated ledger and ouroboros-network dependencies
8c3465b 
Co-authored-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Co-authored-by: Moritz Angermann <moritz.angermann@gmail.com>
Co-authored-by: Marcin Szamotulski <coot@coot.me>
Co-authored-by: Michael Karg <michael.karg@iohk.io>
Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@erikd
cardano-api: Fix Eq instances
64031f5 
The GHC handling of pattern matches has changed for `ghc-9.2` resulting
in incomplete pattern match errors with the old code.
@angerman
Copy link
Contributor

angerman commented Feb 6, 2023

Bors try

iohk-bors bot added a commit that referenced this pull request Feb 6, 2023
@iohk-bors
Try #4701:
496ef3a
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 6, 2023

try

Build succeeded:

angerman
angerman approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's do this!

erikd and others added 10 commits February 6, 2023 01:47
@erikd @angerman
Add support for ghc-9.2 and CHaP
11f654f
@erikd @angerman
CI: Add ghc-9.2.4 to the build matrix
e8ed61a
@jbgi @angerman
Add ghc-9.2.5 variant to nix ci.
76d1c7c
@michaelpj @erikd @angerman
Fix plutus related benchmarking code
1df24e2 
Co-authored-by: Erik de Castro Lopo <erikd@mega-nerd.com>
@jutaro @angerman
cardano-node: restructuring tracers
baf1d4b
@Soupstraw @angerman
Updated ledger and ouroboros-network dependencies
0e8d611
@coot @angerman
Updated cardano-node for 1.35.5 releasefixed
b5640c2 
* fixed formatting
@Soupstraw @erikd
@angerman @coot @mgmeier @Jimbo4350
Updated ledger and ouroboros-network dependencies
5ff7d96 
Co-authored-by: Erik de Castro Lopo <erikd@mega-nerd.com>
Co-authored-by: Moritz Angermann <moritz.angermann@gmail.com>
Co-authored-by: Marcin Szamotulski <coot@coot.me>
Co-authored-by: Michael Karg <michael.karg@iohk.io>
Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
@angerman
Add support for ghc-9.2 and CHaP
b2f4ed2 
Co-authored-by: Moritz Angermann <moritz.angermann@gmail.com>
@angerman
Nix and CI related fixes
7b90482
@angerman
Copy link
Contributor

angerman commented Feb 6, 2023

bors try

iohk-bors bot added a commit that referenced this pull request Feb 6, 2023
@iohk-bors
Try #4701:
43a79b6
@erikd
Copy link
Contributor Author

erikd commented Feb 6, 2023

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 6, 2023

try

Timed out.

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 6, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit 0c5d82b into master Feb 6, 2023
@angerman
Copy link
Contributor

angerman commented Feb 6, 2023

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 6, 2023

Already running a review

@iohk-bors iohk-bors bot deleted the erikd/ghc-9.2 branch February 6, 2023 04:06
@newhoggy newhoggy mentioned this pull request Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newhoggy newhoggy newhoggy left review comments

@angerman angerman angerman approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@coot coot Awaiting requested review from coot

@deepfire deepfire Awaiting requested review from deepfire

@jutaro jutaro Awaiting requested review from jutaro

@mgmeier mgmeier Awaiting requested review from mgmeier

@fmaste fmaste Awaiting requested review from fmaste

@cleverca22 cleverca22 Awaiting requested review from cleverca22

@dcoutts dcoutts Awaiting requested review from dcoutts

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@LudvikGalois LudvikGalois Awaiting requested review from LudvikGalois

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@erikd @angerman @jbgi @newhoggy @Soupstraw @coot @disassembler @michaelpj @jutaro