Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New query stake-snapshot integration test #4805

Merged
merged 1 commit into from
Jan 19, 2023
Merged

New query stake-snapshot integration test #4805

merged 1 commit into from
Jan 19, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Jan 18, 2023 •
edited
Loading

For #4570

@newhoggy newhoggy marked this pull request as ready for review January 18, 2023 10:52
Jimbo4350
Jimbo4350 previously requested changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

cardano-testnet/test/Test/Cli/Babbage/StakeSnapshot.hs Outdated Show resolved Hide resolved
cardano-testnet/test/Test/Cli/Babbage/StakeSnapshot.hs Outdated

let jsonResult = J.eitherDecode @J.Value (LBS.fromStrict (T.encodeUtf8 (T.pack result)))

-- Check that "pools" has three entries
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and therefore there are three registered stake pools?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's right.

@newhoggy newhoggy force-pushed the newhoggy/query-stake-snapshot-integration-test branch from 231a253 to b5b1d57 Compare January 18, 2023 13:26
@newhoggy newhoggy dismissed Jimbo4350’s stale review January 18, 2023 13:28

Comments addressed.

Jimbo4350
Jimbo4350 previously requested changes Jan 18, 2023
View reviewed changes
cardano-testnet/test/Test/Cli/Babbage/StakeSnapshot.hs Outdated Show resolved Hide resolved
cardano-testnet/test/Test/Cli/Babbage/StakeSnapshot.hs Outdated Show resolved Hide resolved
cardano-testnet/test/Test/Cli/Babbage/StakeSnapshot.hs Outdated Show resolved Hide resolved
cardano-testnet/test/Test/Cli/Babbage/StakeSnapshot.hs Outdated Show resolved Hide resolved
cardano-testnet/test/Test/Cli/Babbage/StakeSnapshot.hs Outdated Show resolved Hide resolved
@newhoggy newhoggy force-pushed the newhoggy/query-stake-snapshot-integration-test branch from b5b1d57 to c146209 Compare January 19, 2023 00:02
@newhoggy newhoggy force-pushed the newhoggy/query-stake-snapshot-integration-test branch from c146209 to eb874c1 Compare January 19, 2023 00:07
@newhoggy newhoggy dismissed Jimbo4350’s stale review January 19, 2023 00:08

Comments addressed

@jbgi
Copy link
Contributor

jbgi commented Jan 19, 2023

bors try

iohk-bors bot added a commit that referenced this pull request Jan 19, 2023
@iohk-bors
Try #4805:
68c6214
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 19, 2023

try

Build succeeded:

Jimbo4350
Jimbo4350 approved these changes Jan 19, 2023
View reviewed changes
cardano-testnet/test/Test/Cli/Babbage/StakeSnapshot.hs
( hprop_stakeSnapshot
) where

import Prelude
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks 👍

@newhoggy newhoggy merged commit b5c9f9b into master Jan 19, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/query-stake-snapshot-integration-test branch January 19, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@LudvikGalois LudvikGalois Awaiting requested review from LudvikGalois

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@newhoggy @jbgi @Jimbo4350