Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Straight line code for tx commands #4823

Merged
merged 8 commits into from
Mar 21, 2023

Conversation

newhoggy
Copy link
Contributor

No description provided.

@newhoggy newhoggy force-pushed the newhoggy/straight-line-code-for-tx-commands branch 2 times, most recently from 335c1f5 to 5eb0a7b Compare January 28, 2023 18:35
@newhoggy newhoggy force-pushed the newhoggy/straight-line-code-for-tx-commands branch 2 times, most recently from dd497b9 to 14b6b93 Compare February 13, 2023 05:38
@newhoggy newhoggy marked this pull request as ready for review February 13, 2023 05:44
@newhoggy newhoggy force-pushed the newhoggy/straight-line-code-for-tx-commands branch from 20b4dea to 631b8c9 Compare March 11, 2023 12:57
@newhoggy newhoggy force-pushed the newhoggy/straight-line-code-for-tx-commands branch 2 times, most recently from 7c6ca34 to 9bc940c Compare March 19, 2023 11:29
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

<- firstExceptT (ShelleyTxCmdQueryConvenienceError . AcqFailure)
. newExceptT $ determineEra cModeParams localNodeConnInfo
AnyCardanoEra nodeEra <- lift (determineEra cModeParams localNodeConnInfo)
& onLeft (throwE . ShelleyTxCmdQueryConvenienceError . AcqFailure)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a major deal but I'd like to stick with left in future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed throwE from the commit history of the PR.

@newhoggy newhoggy force-pushed the newhoggy/straight-line-code-for-tx-commands branch from 9bc940c to ba46bd6 Compare March 20, 2023 22:58
@newhoggy newhoggy force-pushed the newhoggy/straight-line-code-for-tx-commands branch from ba46bd6 to 8cf9027 Compare March 20, 2023 23:03
@newhoggy newhoggy added this pull request to the merge queue Mar 20, 2023
@newhoggy newhoggy merged commit 7f52046 into master Mar 21, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/straight-line-code-for-tx-commands branch March 21, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants