Remove NoImplicitPrelude from cardano-api #4832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
force-pushed
the
newhoggy/remove-NoImplicitPrelude-from-cardano-api
branch
from
b84c973
to
18416b5
Compare
newhoggy
changed the title
newhoggy
requested review from
dcoutts,
Jimbo4350,
erikd,
JaredCorduan and
CarlosLopezDeLara
as code owners
newhoggy
force-pushed
the
newhoggy/remove-NoImplicitPrelude-from-cardano-api
branch
from
18416b5
to
2129f33
Compare
Jimbo4350
approved these changes
Jan 24, 2023
| @@ -97,7 +96,6 @@ genCostModels = do | |||
| Right alonzoCostModel -> | |||
| Alonzo.CostModels . conv <$> Gen.list (Range.linear 1 3) (return alonzoCostModel) | |||
| where | |||
| conv :: [Alonzo.CostModel] -> Map Alonzo.Language Alonzo.CostModel | |||
There was a problem hiding this comment.
Why the removal of the type signature here?
There was a problem hiding this comment.
For some reason I got this error with the type signature:
gen/Gen/Cardano/Api.hs:99:33: error:
• Expected kind ‘* -> *’,
but ‘Map Alonzo.Language’ has kind ‘Metadatum’
• In the type signature:
conv :: [Alonzo.CostModel] -> Map Alonzo.Language Alonzo.CostModel
In an equation for ‘genCostModels’:
genCostModels
= do CostModel cModel <- genCostModel
lang <- genLanguage
case Alonzo.mkCostModel lang cModel of
Left err -> panic . Text.pack $ "genCostModels: " <> show err
Right alonzoCostModel
-> Alonzo.CostModels . conv
<$> Gen.list (Range.linear 1 3) (return alonzoCostModel)
where
conv :: [Alonzo.CostModel] -> Map Alonzo.Language Alonzo.CostModel
conv [] = mempty
conv (c : rest)
= Map.singleton (Alonzo.getCostModelLanguage c) c <> conv rest
|
99 | conv :: [Alonzo.CostModel] -> Map Alonzo.Language Alonzo.CostModel
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
There was a problem hiding this comment.
Ah, I need to qualify it:
conv :: [Alonzo.CostModel] -> Map.Map Alonzo.Language Alonzo.CostModel
There was a problem hiding this comment.
I put the type signature back in.
newhoggy
force-pushed
the
newhoggy/remove-NoImplicitPrelude-from-cardano-api
branch
from
2129f33
to
5eb9989
Compare
newhoggy
deleted the
newhoggy/remove-NoImplicitPrelude-from-cardano-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We import Prelude explicitly from the majority of
cardano-apimodules. Removing this language extension makes this unnecessary and removes confusion about the status ofcardano-prelude.