Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ADR-2: Restructure modules for generators #4833

Merged
merged 1 commit into from
Jan 28, 2023
Merged

Implement ADR-2: Restructure modules for generators #4833

merged 1 commit into from
Jan 28, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Jan 24, 2023 •
edited
Loading

Rename:

  • Gen.Cardano.* -> Test.Gen.Cardano.*
  • Hedgehog.* -> Test.Hedgehog.*

See https://github.com/input-output-hk/cardano-node/wiki/ADR-2-Module-structure-for-generators

@newhoggy newhoggy marked this pull request as ready for review January 24, 2023 08:46
@newhoggy newhoggy force-pushed the newhoggy/implement-adr-2 branch 2 times, most recently from e12049f to 9eec1c9 Compare January 27, 2023 08:26
Jimbo4350
Jimbo4350 approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff @newhoggy . Thank you for championing the ADR process.

@newhoggy
Copy link
Contributor Author

bors r+

@newhoggy
Copy link
Contributor Author

bors r-

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 28, 2023

Canceled.

@newhoggy
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jan 28, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit e6f01fe into master Jan 28, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/implement-adr-2 branch January 28, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newhoggy @Jimbo4350