Modify constructBalancedTx to take LedgerEpochInfo #4858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
requested review from
dcoutts,
erikd,
newhoggy,
JaredCorduan and
CarlosLopezDeLara
as code owners
Modify constructBalancedTx to take LedgerEpochInfo instead of EraHistory CardanoMode
Jimbo4350
force-pushed
the
jordan/modify-makeTransactionBodyAutoBalance-epochinfo
branch
from
afc1f25
to
180f41c
Compare
newhoggy
approved these changes
Jan 31, 2023
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
jordan/modify-makeTransactionBodyAutoBalance-epochinfo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifying
constructBalancedTxto takeLedgerEpochInfoinstead ofEraHistory modemakes it significantly easier to use this function with a service such as BlockFrost. Constructing anLedgerEpochInfovalue can be done with the helper function fixedEpochInfo which requires the slot length and the epoch length. Both of these values can be retrieved from the ShelleyGenesis whereas constructing anEraHistory modevalue is difficult without using a local node query (which necessitates running a node locally).