Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of multiline literals #4889

Merged
merged 4 commits into from
Feb 19, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Feb 16, 2023

Also the style-guide in the Wiki has been updated with a new section: https://github.com/input-output-hk/cardano-node/wiki/Style-guide#multi-line-string-literals

Resolves #4585

@newhoggy newhoggy marked this pull request as ready for review February 16, 2023 06:09
@newhoggy newhoggy force-pushed the newhoggy/remove-use-of-multiline-literals branch from 6613614 to 8a16a38 Compare February 16, 2023 06:10
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

<> Opt.help ("TxId#TxIx - Specify a reference input. The reference input must have\
\ a " <> scriptType <> " reference script attached.")
)
Opt.option (readerFromParsecParser parseTxIn) $ mconcat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This style is way better, thanks @newhoggy

@newhoggy newhoggy force-pushed the newhoggy/remove-use-of-multiline-literals branch 2 times, most recently from d1218b6 to e609e9e Compare February 19, 2023 06:00
@newhoggy
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Feb 19, 2023

Build succeeded:

@iohk-bors iohk-bors bot merged commit facefec into master Feb 19, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/remove-use-of-multiline-literals branch February 19, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] - Remove use of Haskell multi-line string literals
2 participants